Skip to content

V5.18.4 all platforms#6497

Merged
pdillinger merged 11 commits intofacebook:5.18.fbfrom
adamretter:v5.18.4-all-platforms
Mar 11, 2020
Merged

V5.18.4 all platforms#6497
pdillinger merged 11 commits intofacebook:5.18.fbfrom
adamretter:v5.18.4-all-platforms

Conversation

@adamretter
Copy link
Copy Markdown
Collaborator

@adamretter adamretter commented Mar 7, 2020 •
edited
Loading

@pdillinger Sorry about this, but there were 11 additional commits I had to pull in to build 5.18.4.

These are because of external changes over the time since I created the last PR for 5.18.4:

  1. Some dependencies are no longer available from their previous locations
  2. Newer version of macOS, has stricter compiler checks.

If you could merge this, and then re-cut the v5.18.4 tag. Then I can check that out and rebuild and release. I think this should be fine now, I have built this branch on all release platforms:

  1. macOS x64
  2. Linux x86
  3. Linux x64
  4. Linux ppc64le
  5. Linux aarch64
  6. Windows x64

adamretter and others added 11 commits March 6, 2020 22:21
@adamretter
Update the version of the dependencies used by the RocksJava static b…
931e670 
…uild (facebook#4761)

Summary:
Note that Snappy now requires CMake to build it, so I added a note about RocksJava to the README.md file.
Pull Request resolved: facebook#4761

Differential Revision: D13403811

Pulled By: ajkr

fbshipit-source-id: 8fcd7e3dc7f7152080364a374d3065472f417eff
@adamretter
Fix build failures due to missing JEMALLOC_CXX_THROW macro (facebook#…
d07167c 
…5053)

Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes facebook#4869
Pull Request resolved: facebook#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
@harrywong @adamretter
Removed const fields in copyable classes (facebook#5095)
3598e1a 
Summary:
This fixed the compile error in Clang-8:
```
error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
```
Pull Request resolved: facebook#5095

Differential Revision: D14811961

Pulled By: riversand963

fbshipit-source-id: d935d1f85a4e8694dca10033fb5af92d8777eca0
@siying @adamretter
Rename InternalDBStatsType enum names (facebook#5779)
fc38b0d 
Summary:
When building with clang 9, warning is reported for InternalDBStatsType type names shadowed the one for statistics. Rename them.
Pull Request resolved: facebook#5779

Test Plan: Build with clang 9 and see it passes.

Differential Revision: D17239378

fbshipit-source-id: af28fb42066c738cd1b841f9fe21ab4671dafd18
@Myasuka @adamretter
Download bzip2 packages from sourceforge (facebook#5995)
49f97dc 
Summary:
From bzip2's official [download page](http://www.bzip.org/downloads.html), we could download it from sourceforge. This source would be more credible than previous web archive.
Pull Request resolved: facebook#5995

Differential Revision: D18377662

fbshipit-source-id: e8353f83d5d6ea6067f78208b7bfb7f0d5b49c05
@adamretter
Update 3rd-party libraries used by RocksJava (facebook#6084)
03492d6 
Summary:
* LZ4 1.8.3 -> 1.9.2
* ZSTD 1.4.0 -> 1.4.4
Pull Request resolved: facebook#6084

Differential Revision: D18710224

fbshipit-source-id: a461ef19a473d3480acdc027f627ec3048730692
@pdillinger @adamretter
Don't download from (unreliable) maven.org (facebook#6348)
614c6d4 
Summary:
I set up a mirror of our Java deps on github so we can download
them through github URLs rather than maven.org, which is proving
terribly unreliable from Travis builds.

Also sanitized calls to curl, so they are easier to read and
appropriately fail on download failure.
Pull Request resolved: facebook#6348

Test Plan: CI

Differential Revision: D19633621

Pulled By: pdillinger

fbshipit-source-id: 7eb3f730953db2ead758dc94039c040f406790f3
@adamretter
Update to latest Snappy to fix compilation issue on latest MacOS XCode
466af89
@adamretter
RocksJava must compile on JDK7 (facebook#4768)
64dbc78 
Summary:
Fixes some RocksJava regressions recently introduced, whereby RocksJava would not build on JDK 7.
These should have been visible on Travis-CI!
Pull Request resolved: facebook#4768

Differential Revision: D13418173

Pulled By: sagar0

fbshipit-source-id: 57bf223188887f84d9e072031af2e0d2c8a69c30
@adamretter
Snappy must be built with position independent code for static linking
1c63b82
@adamretter
Fix build on MSVC
b9a4a10
@adamretter adamretter added bug Confirmed RocksDB bugs java-api labels Mar 7, 2020
@adamretter adamretter requested a review from pdillinger March 7, 2020 17:00
@adamretter adamretter mentioned this pull request Mar 9, 2020
Merged
pdillinger
pdillinger requested changes Mar 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at Travis, slightly concerned about the cmake-gcc8 failure:

/tmp/cc0UbblJ.s: Assembler messages:
/tmp/cc0UbblJ.s:2773: Error: operand size mismatch for vmovdqu64' /tmp/cc0UbblJ.s:2774: Error: operand size mismatch for vmovdqu64'

This looks like an old assembler being used with a new compiler.

@adamretter adamretter force-pushed the v5.18.4-all-platforms branch from f275333 to ee68e03 Compare March 10, 2020 11:16
@pdillinger pdillinger force-pushed the v5.18.4-all-platforms branch 2 times, most recently from 46fcb3e to b9a4a10 Compare March 11, 2020 05:09
@pdillinger
Copy link
Copy Markdown
Contributor

pdillinger commented Mar 11, 2020

I'm calling a timeout on making Travis happy and merging+tagging b9a4a10 as requested.

@pdillinger pdillinger merged commit b9a4a10 into facebook:5.18.fb Mar 11, 2020
@pdillinger
Copy link
Copy Markdown
Contributor

pdillinger commented Mar 11, 2020

For the record, example force update of an existing tag AND make sure it's not listed as "latest release" in github project:

$ git tag -d v5.18.4
Deleted tag 'v5.18.4' (was 6ea4477cf)
$ GIT_COMMITTER_DATE="Mon, 27 Jan 2020 08:21:13 -0800" git tag -f -a v5.18.4 5.18.fb
<enter a message>
$ git push -f origin refs/tags/v5.18.4

Suggested message info: (Note: the originally tagged commit for this release was wrong but the tag has been updated. You might need to delete your copy of the tag with git tag -d v5.18.4 to get the new one. See https://git-scm.com/docs/git-tag#_on_re_tagging)

jiameixie added a commit to jiameixie/kafka that referenced this pull request Mar 12, 2020
@jiameixie
Bump rocksdb 5.18.3 to 5.18.4
71cf5c2 
Bump rocksdb 5.18.3 to 5.18.4 that supports all platforms.
Issues about this version are facebook/rocksdb#6497
and facebook/rocksdb#6188

Change-Id: I3febec8e36550edcb7f88839cc1e2b2a54984564
Signed-off-by: Jiamei Xie <jiamei.xie@arm.com>
@jiameixie jiameixie mentioned this pull request Mar 12, 2020
Merged
3 tasks
@dzdx dzdx mentioned this pull request Jul 13, 2020
Closed
fengjiachun added a commit to sofastack/sofa-jraft that referenced this pull request Jul 13, 2020
@fengjiachun
upgrade rocksdb(v5.18.4) for aarch64 facebook/rocksdb#6497
d6d1b27
@fengjiachun fengjiachun mentioned this pull request Jul 13, 2020
Merged
9 tasks
killme2008 pushed a commit to sofastack/sofa-jraft that referenced this pull request Jul 29, 2020
@fengjiachun
some fix/improve (#489)
136cf10 
* typo

* [feat] impl Describer for RouteTable

* [feat] impl Describer for RegionEngine

* [feat] impl Describer for StoreEngine

* [feat] impl Describer for StoreEngine

* [rheakv] avoid sending repeatedly

* [rheakv] avoid sending repeatedly

* lock free improve

* format

* upgrade rocksdb(v5.18.4) for aarch64 facebook/rocksdb#6497

* upgrade bolt to 1.6.2

* read-index ut

* let append-entry fail-fast

* typo

* rocksdb:5.18.3

* add weak read for `isLeader()`

* improve `checkDeadNodes`

* improve `checkDeadNodes`

* fail-fast on `addReplicator`

* format

* add `LongHeldDetectingReadWriteLock`

* add node-lock-blocked metric

* add UT: LongHeldDetectingReadWriteLockTest

* by CR

* by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdillinger pdillinger pdillinger requested changes

Assignees

No one assigned

Labels

bug Confirmed RocksDB bugs CLA Signed java-api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adamretter @pdillinger @facebook-github-bot @harrywong @siying @Myasuka