Skip to content

KAFKA-2734: kafka-console-consumer throws NoSuchElementException on n…#412

Closed
SinghAsDev wants to merge 2 commits intoapache:trunkfrom
SinghAsDev:KAFKA-2734
Closed

KAFKA-2734: kafka-console-consumer throws NoSuchElementException on n…#412
SinghAsDev wants to merge 2 commits intoapache:trunkfrom
SinghAsDev:KAFKA-2734

Conversation

@SinghAsDev
Copy link
Copy Markdown
Contributor

@SinghAsDev SinghAsDev commented Nov 3, 2015

…ot specifying topic

@SinghAsDev
Copy link
Copy Markdown
Contributor Author

SinghAsDev commented Nov 3, 2015

@gwenshap this is worth taking a look. Not a blocker, but affects users and is probably on most common users' path.

@harshach
Copy link
Copy Markdown

harshach commented Nov 4, 2015

@SinghAsDev I am noticing this as well. we should get this into 0.9. I see a unit test failing
unit.kafka.tools.ConsoleConsumerTest > shouldParseValidOldConsumerValidConfig FAILED
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at unit.kafka.tools.ConsoleConsumerTest.shouldParseValidOldConsumerValidConfig(ConsoleConsumerTest.scala:67)
can you please fix that.

@SinghAsDev
Copy link
Copy Markdown
Contributor Author

SinghAsDev commented Nov 5, 2015

Sure Harsha, I will look into the test failure.

On Wed, Nov 4, 2015 at 11:16 AM, Harsha notifications@github.com wrote:

@SinghAsDev https://github.com/SinghAsDev I am noticing this as well.
we should get this into 0.9. I see a unit test failing
unit.kafka.tools.ConsoleConsumerTest >
shouldParseValidOldConsumerValidConfig FAILED
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
unit.kafka.tools.ConsoleConsumerTest.shouldParseValidOldConsumerValidConfig(ConsoleConsumerTest.scala:67)
can you please fix that.

—
Reply to this email directly or view it on GitHub
#412 (comment).

Regards,
Ashish

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Nov 5, 2015

With the new consumer, people can still specify "whielist" with regex subscription, can we incorporate this?

@SinghAsDev
Copy link
Copy Markdown
Contributor Author

SinghAsDev commented Nov 6, 2015

@guozhangwang that will require some changes to NewShinyConsumer and is probably out of scope of this JIRA. I will create a separate JIRA for that and provide a patch. This JIRA is just to avoid users getting weird exception, instead of usage info, when none of topic or whitelist or blacklist is specified. Even if we support whitelist for new consumer, this issue will still be there.

@SinghAsDev SinghAsDev mentioned this pull request Nov 6, 2015
Closed
@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Nov 6, 2015

LGTM.

@asfgit asfgit closed this in a9e4ce7 Nov 6, 2015
asfgit pushed a commit that referenced this pull request Nov 8, 2015
@guozhangwang
KAFKA-2761: enable whitelist regex subscription for new consumer in C…
34d9976 
…onsoleConsumer

#412 is a pre-req.

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Guozhang Wang

Closes #445 from SinghAsDev/KAFKA-2761
granders referenced this pull request in confluentinc/kafka Nov 18, 2015
KAFKA-2761: enable whitelist regex subscription for new consumer in C…
7001acc 
…onsoleConsumer

#412 is a pre-req.

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Guozhang Wang

Closes #445 from SinghAsDev/KAFKA-2761
efeg pushed a commit to efeg/kafka that referenced this pull request Jan 29, 2020
Add parameter skip_urp_demotion and exclude_follower_demotion to demo…
fcfbfed 
…te_broker endpoint. (apache#412)
abbccdda pushed a commit to abbccdda/kafka that referenced this pull request Oct 2, 2020
Cherry-pick commits to KsqlDB 0.13 release (apache#412)
5abcd42 
Cherry-picking following PRs:
- apache@7e7bb18
- apache@5ee3ecb
- apache@bc7674f
- apache@bd462df

test failure fixes:
- apache@1443f24
- apache@e4eab37
- apache@e9251a1

Reviewers: John Roesler <vvcephei@users.noreply.github.com>
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
@jeqo
refactor(inkless): add fetch fan-out metrics (apache#412)
6506750 
* refactor(inkless): add fetch fan-out metrics

Consumer fetch requests require a fan-out in number of batches to
include to serve them. These batches may be across multiple objects.

Adding histogramns to measure how do these fan-outs look like:
partitions per request, batches per partitions, objects per request.

* fixup! refactor(inkless): add fetch fan-out metrics
jeqo added a commit to aiven/kafka that referenced this pull request Jan 16, 2026
@jeqo
refactor(inkless): add fetch fan-out metrics (apache#412)
f0644bd 
* refactor(inkless): add fetch fan-out metrics

Consumer fetch requests require a fan-out in number of batches to
include to serve them. These batches may be across multiple objects.

Adding histogramns to measure how do these fan-outs look like:
partitions per request, batches per partitions, objects per request.

* fixup! refactor(inkless): add fetch fan-out metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SinghAsDev @harshach @guozhangwang