Closed
Conversation
Contributor
Author
|
@guozhangwang this should take care of your concern on KAFKA-2734. I like to keep separate concerns in separate commits, as it makes it easier to cherry-pick and follow. I hope it makes sense. Also, note that this branch already has KAFKA-2734, which is a pre-req to this PR, cherry-picked to help reviewers try out the changes locally. |
Contributor
|
@SinghAsDev Could you rebase? |
SinghAsDev
force-pushed
the
KAFKA-2761
branch
from
ed75c47 to
b0d9ed5
Compare
Contributor
Author
|
@guozhangwang done |
Contributor
There was a problem hiding this comment.
Could this happen with the check in ConsoleConsumer?
Contributor
Author
There was a problem hiding this comment.
This check is actually redundant, as it is also happening in ConsoleConsumer. However, the check just seemed to be natural here. Let me know if you are in favor of removing it.
Contributor
There was a problem hiding this comment.
I was originally thinking if it should not ever happen let's remove it, after another thought I feel it may be OK to leave it as is.
Contributor
|
LGTM, thanks. |
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Dec 8, 2020
…ng loop (apache#445) This patch does the following: 1) Events are handled in order. The previous logic attempted to route the out-of-band registration/fencing messages to the front of the queue, but it seems simpler to let them be handled in order. I am not sure it is worthwhile optimizing for the case when there is a backlog of events to be processed. 2) Event failures are propagated. Previously we incremented an error counter, but an event failure leaves the broker state machine in an indeterminate state and it seems dangerous to try and continue. 3) Simplify processor API. Rather than overloading `process`, we can use a single method and let the processor `match` on the events it wants to handle. 4) Hook up `MetaLogManager.Listener`. The only real change here is that I preferred to retain the java List type since it awkwardly converts to the `Buffer` type with the scala collection converters.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 22, 2023
…plicas on parition assignment cancellation (apache#445) This should be a direct fix-up to the commit - 28cca3e Cancellation of reassignments allowed if the resulting ISR is at min-ISR (apache#442)
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
…e#445) * feat(inkless): support loading google access token credentials If service account impersonation is used, then a plain access token is used for authentication. * fix(inkless): fix reloading Gcs credentials GoogleCredentials.equals returned true by comparing only public fields. Simply always reset Storage instance with given credentials.
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
…e#445) * feat(inkless): support loading google access token credentials If service account impersonation is used, then a plain access token is used for authentication. * fix(inkless): fix reloading Gcs credentials GoogleCredentials.equals returned true by comparing only public fields. Simply always reset Storage instance with given credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#412 is a pre-req.