Skip to content

MINOR: Java 9/10 fixes, gradle and minor deps update#4725

Merged
ijuma merged 6 commits intoapache:trunkfrom
ijuma:java9-10-fixes
Mar 23, 2018
Merged

MINOR: Java 9/10 fixes, gradle and minor deps update#4725
ijuma merged 6 commits intoapache:trunkfrom
ijuma:java9-10-fixes

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Mar 16, 2018 •
edited
Loading

  • Added dependencies so that Trogdor and Connect work with Java 9 and 10
  • Updated Jacoco to 0.8.1 so that it works with Java 10
  • Updated Gradle to 4.6
  • A few minor version bumps (not related to Java9/10 fixes)

I tested manually that we can run ./gradlew test with Java 10
after these changes. There are test failures as EasyMock
and PowerMock will have to be updated to use a newer
ASM version. But compiling successfully and most tests
passing is progress. :)

I also tested manually that Trogdor can be started with Java 10.
It previously failed with a ClassNotFoundError.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 16, 2018

retest this please

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 16, 2018

All tests passed, the JDK 8/Scala 2.12 issue was when talking to GitHub after the tests had passed.

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Mar 16, 2018

LGTM

@ijuma ijuma assigned rajinisivaram and unassigned hachikuji Mar 19, 2018
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 22, 2018

There's a new version of Jacoco that works with Java 10 and I updated connect in a similar way as Trogdor.

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 22, 2018

retest this please

hachikuji
hachikuji approved these changes Mar 22, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming it builds successfully)

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 23, 2018

Failure is unrelated. Merging to trunk.

@ijuma ijuma merged commit 395dcad into apache:trunk Mar 23, 2018
hejiefang pushed a commit to hejiefang/kafka that referenced this pull request Mar 26, 2018
@ijuma
MINOR: Java 9/10 fixes, gradle and minor deps update (apache#4725)
7c853f1 
* Added dependencies so that Trogdor and Connect work with Java 9 and 10
* Updated Jacoco to 0.8.1 so that it works with Java 10
* Updated Gradle to 4.6
* A few minor version bumps (not related to Java9/10 fixes)

I tested manually that we can run ./gradlew test with Java 10
after these changes. There are test failures as EasyMock
and PowerMock will have to be updated to use a newer
ASM version. But compiling successfully and most tests
passing is progress. :)

I also tested manually that Trogdor can be started with Java 10.
It previously failed with a ClassNotFoundError.

Reviewers: Jason Gustafson <jason@confluent.io>
ijuma added a commit that referenced this pull request Apr 12, 2018
@ijuma
MINOR: Java 9/10 fixes, gradle and minor deps update (#4725)
3a5d86e 
* Added dependencies so that Trogdor and Connect work with Java 9 and 10
* Updated Jacoco to 0.8.1 so that it works with Java 10
* Updated Gradle to 4.6
* A few minor version bumps (not related to Java9/10 fixes)

I tested manually that we can run ./gradlew test with Java 10
after these changes. There are test failures as EasyMock
and PowerMock will have to be updated to use a newer
ASM version. But compiling successfully and most tests
passing is progress. :)

I also tested manually that Trogdor can be started with Java 10.
It previously failed with a ClassNotFoundError.

Reviewers: Jason Gustafson <jason@confluent.io>
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 25, 2018
@ijuma
Merge remote-tracking branch 'confluent/1.1' into 4.1.x-with-interceptor
98c0a61 
* confluent/1.1: (60 commits)
  MINOR: Fix kafka-run-class for Java 10 (apache#4895)
  KAFKA-6772: Load credentials from ZK before accepting connections (apache#4867)
  KAFKA-6742: TopologyTestDriver error when dealing with stores from GlobalKTable
  MINOR: Mention that -1 disables retention by time (apache#4881)
  KAFKA-6790: Fix Streams processor node broken link (apache#4874)
  MINOR: Java 10 fixes so that the build passes (apache#4839)
  MINOR: Update Jackson to 2.9.5 (apache#4776)
  MINOR: Downgrade to Gradle 4.5.1 (apache#4791)
  MINOR: Java 9/10 fixes, gradle and minor deps update (apache#4725)
  KAFKA-6752: Enable unclean leader election metric (apache#4838)
  KAFKA-6054: Fix upgrade path from Kafka Streams v0.10.0 (apache#4773)
  KAFKA-6747 Check whether there is in-flight transaction before aborting transaction (apache#4826)
  KAFKA-6748: double check before scheduling a new task after the punctuate call (apache#4827)
  KAFKA-6739; Ignore headers when down-converting from V2 to V0/V1 (apache#4813)
  KAFKA-6728: Corrected the worker’s instantiation of the HeaderConverter
  KAFKA-6731: waitOnState should check the state to be the target start. (apache#4808)
  HOTFIX: Enforce a rebalance upon task migration (apache#4802)
  MINOR: Remove 1.2.0 changes from streams doc (apache#4784)
  MINOR: Update version numbers to 1.1.1-SNAPSHOT
  MINOR: Fix ReassignPartitionsClusterTest.testHwAfterPartitionReassignment test (apache#4781)
  ...
allenxwang pushed a commit to allenxwang/kafka that referenced this pull request Aug 24, 2018
Merge pull request apache#76 in DATA_PIPELINE/kafka from ~AWANG/kafka…
1ab0f95 
…:1.1-nflx to 1.1-nflx

* commit '84eeea7fe4b3a64b84b87d231969acfee4fb7544':
  Fix a bug where the ReqeustPerSec API version hash map is not updated.
  KAFKA-6772: Load credentials from ZK before accepting connections (apache#4867)
  KAFKA-6742: TopologyTestDriver error when dealing with stores from GlobalKTable
  MINOR: Mention that -1 disables retention by time (apache#4881)
  KAFKA-6790: Fix Streams processor node broken link (apache#4874)
  MINOR: Java 10 fixes so that the build passes (apache#4839)
  MINOR: Update Jackson to 2.9.5 (apache#4776)
  MINOR: Downgrade to Gradle 4.5.1 (apache#4791)
  MINOR: Java 9/10 fixes, gradle and minor deps update (apache#4725)
  KAFKA-6752: Enable unclean leader election metric (apache#4838)
  KAFKA-6054: Fix upgrade path from Kafka Streams v0.10.0 (apache#4773)
  KAFKA-6747 Check whether there is in-flight transaction before aborting transaction (apache#4826)
  KAFKA-6748: double check before scheduling a new task after the punctuate call (apache#4827)
@ijuma ijuma deleted the java9-10-fixes branch September 11, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hachikuji hachikuji hachikuji approved these changes

Assignees

@rajinisivaram rajinisivaram

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ijuma @cmccabe @hachikuji @rajinisivaram