Skip to content

MINOR: Remove 1.2.0 changes from 1.1 streams doc#4784

Merged
rajinisivaram merged 1 commit intoapache:1.1from
rajinisivaram:MINOR-streams-doc-1.1
Mar 28, 2018
Merged

MINOR: Remove 1.2.0 changes from 1.1 streams doc#4784
rajinisivaram merged 1 commit intoapache:1.1from
rajinisivaram:MINOR-streams-doc-1.1

Conversation

@rajinisivaram
Copy link
Copy Markdown
Contributor

@rajinisivaram rajinisivaram commented Mar 28, 2018

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented Mar 28, 2018

Hey @rajinisivaram, good catch! This LGTM, but I'm not a committer.

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented Mar 28, 2018 •
edited
Loading

Unrelated failures were:

00:38:42.445 kafka.server.DynamicBrokerReconfigurationTest > testAddRemoveSaslListeners FAILED
00:38:42.445     java.util.concurrent.ExecutionException: java.lang.AssertionError: expected:<0> but was:<1>
00:38:42.445         at java.util.concurrent.FutureTask.report(FutureTask.java:122)
00:38:42.445         at java.util.concurrent.FutureTask.get(FutureTask.java:206)
00:38:42.445         at kafka.server.DynamicBrokerReconfigurationTest.verifyTimeout(DynamicBrokerReconfigurationTest.scala:1211)
00:38:42.445         at kafka.server.DynamicBrokerReconfigurationTest.verifyConnectionFailure(DynamicBrokerReconfigurationTest.scala:1205)
00:38:42.445         at kafka.server.DynamicBrokerReconfigurationTest.verifyRemoveListener(DynamicBrokerReconfigurationTest.scala:809)
00:38:42.445         at kafka.server.DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners(DynamicBrokerReconfigurationTest.scala:717)
00:38:42.445 
00:38:42.445         Caused by:
00:38:42.445         java.lang.AssertionError: expected:<0> but was:<1>

and

00:40:05.192 kafka.server.DynamicBrokerReconfigurationTest > testAddRemoveSslListener FAILED
00:40:05.192     java.util.concurrent.ExecutionException: java.lang.AssertionError: expected:<0> but was:<1>
00:40:05.192         at java.util.concurrent.FutureTask.report(FutureTask.java:122)
00:40:05.192         at java.util.concurrent.FutureTask.get(FutureTask.java:206)
00:40:05.192         at kafka.server.DynamicBrokerReconfigurationTest.verifyTimeout(DynamicBrokerReconfigurationTest.scala:1211)
00:40:05.192         at kafka.server.DynamicBrokerReconfigurationTest.verifyConnectionFailure(DynamicBrokerReconfigurationTest.scala:1205)
00:40:05.192         at kafka.server.DynamicBrokerReconfigurationTest.verifyRemoveListener(DynamicBrokerReconfigurationTest.scala:809)
00:40:05.192         at kafka.server.DynamicBrokerReconfigurationTest.testAddRemoveSslListener(DynamicBrokerReconfigurationTest.scala:705)
00:40:05.192 
00:40:05.192         Caused by:
00:40:05.192         java.lang.AssertionError: expected:<0> but was:<1>

Triggering another run of the tests:

Retest this, please.

guozhangwang
guozhangwang approved these changes Mar 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajinisivaram

mjsax
mjsax approved these changes Mar 28, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rajinisivaram !

@rajinisivaram
Copy link
Copy Markdown
Contributor Author

rajinisivaram commented Mar 28, 2018

Thanks @vvcephei @guozhangwang @mjsax for the review, merging to 1.1.

@rajinisivaram rajinisivaram merged commit c765a88 into apache:1.1 Mar 28, 2018
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 25, 2018
@ijuma
Merge remote-tracking branch 'confluent/1.1' into 4.1.x-with-interceptor
98c0a61 
* confluent/1.1: (60 commits)
  MINOR: Fix kafka-run-class for Java 10 (apache#4895)
  KAFKA-6772: Load credentials from ZK before accepting connections (apache#4867)
  KAFKA-6742: TopologyTestDriver error when dealing with stores from GlobalKTable
  MINOR: Mention that -1 disables retention by time (apache#4881)
  KAFKA-6790: Fix Streams processor node broken link (apache#4874)
  MINOR: Java 10 fixes so that the build passes (apache#4839)
  MINOR: Update Jackson to 2.9.5 (apache#4776)
  MINOR: Downgrade to Gradle 4.5.1 (apache#4791)
  MINOR: Java 9/10 fixes, gradle and minor deps update (apache#4725)
  KAFKA-6752: Enable unclean leader election metric (apache#4838)
  KAFKA-6054: Fix upgrade path from Kafka Streams v0.10.0 (apache#4773)
  KAFKA-6747 Check whether there is in-flight transaction before aborting transaction (apache#4826)
  KAFKA-6748: double check before scheduling a new task after the punctuate call (apache#4827)
  KAFKA-6739; Ignore headers when down-converting from V2 to V0/V1 (apache#4813)
  KAFKA-6728: Corrected the worker’s instantiation of the HeaderConverter
  KAFKA-6731: waitOnState should check the state to be the target start. (apache#4808)
  HOTFIX: Enforce a rebalance upon task migration (apache#4802)
  MINOR: Remove 1.2.0 changes from streams doc (apache#4784)
  MINOR: Update version numbers to 1.1.1-SNAPSHOT
  MINOR: Fix ReassignPartitionsClusterTest.testHwAfterPartitionReassignment test (apache#4781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjsax mjsax mjsax approved these changes

@guozhangwang guozhangwang guozhangwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajinisivaram @vvcephei @mjsax @guozhangwang