Kafka-6693: Added consumer workload to Trogdor#4775
Kafka-6693: Added consumer workload to Trogdor#4775rajinisivaram merged 5 commits intoapache:trunkfrom
Conversation
There was a problem hiding this comment.
Should be CREATE_TOPICS_REQUEST_TIMEOUT for consistency
There was a problem hiding this comment.
We should have a clientConf as well, right-- as per the discussion earlier about admin client security configs
There was a problem hiding this comment.
Yes, added commonConf and adminClientConf.
|
Looks good overall. Thanks, @apovzner |
rajinisivaram
left a comment
There was a problem hiding this comment.
@apovzner Thanks for the PR. Looks good, left a few minor comments.
There was a problem hiding this comment.
Perhaps we should change the name of CREATE_TOPICS_REQUEST_TIMEOUT since it used as timeout for ListTopicsRequest and DescribeTopicsRequest.
There was a problem hiding this comment.
Perhaps it is better to check isInternal first to avoid doing the regex match unnecessarily?
There was a problem hiding this comment.
It feels odd to set this.consumer to null here. I was expecting any previous value to be set to null immediately after the consumer is closed. Otherwise, there ought to be a consumer.close() before setting to null. Since stop closes and sets consumer to null, perhaps we dont need this here?
There was a problem hiding this comment.
Yes, stop() closes the consumer and sets to null anyway, and we guard agains multiple start() or close() calls. I will remove setting it to null here.
There was a problem hiding this comment.
Can we use either records or messages consistently?
There was a problem hiding this comment.
I will change to ConsumeMessages since we use word message everywhere.
There was a problem hiding this comment.
Could use Utils.mkSet()
There was a problem hiding this comment.
Could use Utils.mkSet
f478c8f to
28b4569
Compare
rajinisivaram
left a comment
There was a problem hiding this comment.
@apovzner Thanks for the updates, LGTM
|
Merging to trunk. |
Added consumer only workload to Trogdor. The topics must already be pre-populated. The spec lets the user request topic pattern and range of partitions to assign to [startPartition, endPartition]. Reviewers: Colin P. Mccabe <cmccabe@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
Added consumer only workload to Trogdor. The topics must already be pre-populated. The spec lets the user request topic pattern and range of partitions to assign to [startPartition, endPartition].
Committer Checklist (excluded from commit message)