-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Kafka-6693: Added consumer workload to Trogdor #4775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9696486
WorkerUtils method to get matching topic partitions
apovzner 1401fe5
Kafka-6693: Added consumer workload
apovzner caee269
Fixed percentiles
apovzner b4b0e76
addressed review comments
apovzner 28b4569
rebased and fixed merge issues
apovzner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
tools/src/main/java/org/apache/kafka/trogdor/workload/ConsumeBenchSpec.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.kafka.trogdor.workload; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| import org.apache.kafka.trogdor.common.Topology; | ||
| import org.apache.kafka.trogdor.task.TaskController; | ||
| import org.apache.kafka.trogdor.task.TaskSpec; | ||
| import org.apache.kafka.trogdor.task.TaskWorker; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| /** | ||
| * The specification for a benchmark that produces messages to a set of topics. | ||
| */ | ||
| public class ConsumeBenchSpec extends TaskSpec { | ||
|
|
||
| private final String consumerNode; | ||
| private final String bootstrapServers; | ||
| private final int targetMessagesPerSec; | ||
| private final int maxMessages; | ||
| private final Map<String, String> consumerConf; | ||
| private final Map<String, String> adminClientConf; | ||
| private final Map<String, String> commonClientConf; | ||
| private final String topicRegex; | ||
| private final int startPartition; | ||
| private final int endPartition; | ||
|
|
||
|
|
||
| @JsonCreator | ||
| public ConsumeBenchSpec(@JsonProperty("startMs") long startMs, | ||
| @JsonProperty("durationMs") long durationMs, | ||
| @JsonProperty("consumerNode") String consumerNode, | ||
| @JsonProperty("bootstrapServers") String bootstrapServers, | ||
| @JsonProperty("targetMessagesPerSec") int targetMessagesPerSec, | ||
| @JsonProperty("maxMessages") int maxMessages, | ||
| @JsonProperty("consumerConf") Map<String, String> consumerConf, | ||
| @JsonProperty("commonClientConf") Map<String, String> commonClientConf, | ||
| @JsonProperty("adminClientConf") Map<String, String> adminClientConf, | ||
| @JsonProperty("topicRegex") String topicRegex, | ||
| @JsonProperty("startPartition") int startPartition, | ||
| @JsonProperty("endPartition") int endPartition) { | ||
| super(startMs, durationMs); | ||
| this.consumerNode = (consumerNode == null) ? "" : consumerNode; | ||
| this.bootstrapServers = (bootstrapServers == null) ? "" : bootstrapServers; | ||
| this.targetMessagesPerSec = targetMessagesPerSec; | ||
| this.maxMessages = maxMessages; | ||
| this.consumerConf = configOrEmptyMap(consumerConf); | ||
| this.commonClientConf = configOrEmptyMap(commonClientConf); | ||
| this.adminClientConf = configOrEmptyMap(adminClientConf); | ||
| this.topicRegex = topicRegex; | ||
| this.startPartition = startPartition; | ||
| this.endPartition = endPartition; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String consumerNode() { | ||
| return consumerNode; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String bootstrapServers() { | ||
| return bootstrapServers; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public int targetMessagesPerSec() { | ||
| return targetMessagesPerSec; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public int maxMessages() { | ||
| return maxMessages; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public Map<String, String> consumerConf() { | ||
| return consumerConf; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public Map<String, String> commonClientConf() { | ||
| return commonClientConf; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public Map<String, String> adminClientConf() { | ||
| return adminClientConf; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String topicRegex() { | ||
| return topicRegex; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public int startPartition() { | ||
| return startPartition; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public int endPartition() { | ||
| return endPartition; | ||
| } | ||
|
|
||
| @Override | ||
| public TaskController newController(String id) { | ||
| return new TaskController() { | ||
| @Override | ||
| public Set<String> targetNodes(Topology topology) { | ||
| return Collections.singleton(consumerNode); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| @Override | ||
| public TaskWorker newTaskWorker(String id) { | ||
| return new ConsumeBenchWorker(id, this); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a clientConf as well, right-- as per the discussion earlier about admin client security configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added commonConf and adminClientConf.