MINOR: Update dynamic broker configuration doc for truststore update#4954
Merged
hachikuji merged 1 commit intoapache:trunkfrom May 10, 2018
Merged
Conversation
Contributor
|
LGTM |
hachikuji
reviewed
May 9, 2018
| <li><code>log.message.timestamp.difference.max.ms</code></li> | ||
| </ul> | ||
|
|
||
| From Kafka version 2.0.0 onwards, unclean leader election is automatically enabled by the controller when the config |
Contributor
There was a problem hiding this comment.
Maybe we could leave this out of this PR and @omkreddy can include it in the patch for KAFKA-6835?
Contributor
Author
There was a problem hiding this comment.
@hachikuji The changes to the controller for dynamic broker config update was made under https://issues.apache.org/jira/browse/KAFKA-6526 (already merged). So I thought it will be good to update the broker config doc for default topic configuration. @omkreddy is updating the controller for per-topic-override of unclean.leader.election.enable and I think his patch includes changes to the upgrade docs.
Contributor
There was a problem hiding this comment.
Ah, ok. I missed the difference between KAFKA-6835 and KAFKA-6526.
hachikuji
approved these changes
May 10, 2018
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM, thanks for the patch!
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 11, 2018
…-record-version * apache-github/trunk: KAFKA-6894: Improve err msg when connecting processor with global store (apache#5000) KAFKA-6893; Create processors before starting acceptor in SocketServer (apache#4999) MINOR: Fix typo in ConsumerRebalanceListener JavaDoc (apache#4996) MINOR: Remove deprecated valueTransformer.punctuate (apache#4993) MINOR: Update dynamic broker configuration doc for truststore update (apache#4954) KAFKA-6870 Concurrency conflicts in SampledStat (apache#4985) KAFKA-6361: Fix log divergence between leader and follower after fast leader fail over (apache#4882) KAFKA-6813: Remove deprecated APIs in KIP-182, Part II (apache#4976) KAFKA-6878 Switch the order of underlying.init and initInternal (apache#4988) KAFKA-6299; Fix AdminClient error handling when metadata changes (apache#4295) KAFKA-6878: NPE when querying global state store not in READY state (apache#4978) KAFKA 6673: Implemented missing override equals method (apache#4745) KAFKA-6834: Handle compaction with batches bigger than max.message.bytes (apache#4953)
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…pache#4954) Reviewers: Manikumar Reddy O <manikumar.reddy@gmail.com>, Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)