KAFKA-6870 Concurrency conflicts in SampledStat#4985
Merged
rajinisivaram merged 3 commits intoapache:trunkfrom May 10, 2018
Merged
KAFKA-6870 Concurrency conflicts in SampledStat#4985rajinisivaram merged 3 commits intoapache:trunkfrom
rajinisivaram merged 3 commits intoapache:trunkfrom
Conversation
Contributor
|
@chia7712 Can you add one unit test please? |
Member
Author
Copy that. |
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@chia7712 Thanks for the PR. Looks good, left a few minor comments.
| return ((Measurable) metricValueProvider).measure(config, timeMs); | ||
| else | ||
| return 0; | ||
| } |
Contributor
There was a problem hiding this comment.
nit: unnecessary newline
| })); | ||
| } | ||
| latch.countDown(); | ||
| service.shutdown(); |
Contributor
There was a problem hiding this comment.
we need to shutdown the executor service even if there is a test failure (either in a finally block or the teardown).
| assertTrue(service.awaitTermination(10, TimeUnit.SECONDS)); | ||
| for (Future<Throwable> callable : workers) { | ||
| assertTrue(callable.isDone()); | ||
| assertNull(callable.get()); |
Contributor
There was a problem hiding this comment.
Can we add error messages for these assertions?
Member
Author
|
Thanks for the reviews. @rajinisivaram I have addressed you comment in the latest commit. Please take a look. |
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@chia7712 Thanks for the update, LGTM. Will merge after PR builds complete.
rajinisivaram
approved these changes
May 10, 2018
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@chia7712 Thanks for the PR, merging to trunk and 1.1.
rajinisivaram
pushed a commit
that referenced
this pull request
May 10, 2018
Make `KafkaMetric.measurableValue` thread-safe Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 11, 2018
…-record-version * apache-github/trunk: KAFKA-6894: Improve err msg when connecting processor with global store (apache#5000) KAFKA-6893; Create processors before starting acceptor in SocketServer (apache#4999) MINOR: Fix typo in ConsumerRebalanceListener JavaDoc (apache#4996) MINOR: Remove deprecated valueTransformer.punctuate (apache#4993) MINOR: Update dynamic broker configuration doc for truststore update (apache#4954) KAFKA-6870 Concurrency conflicts in SampledStat (apache#4985) KAFKA-6361: Fix log divergence between leader and follower after fast leader fail over (apache#4882) KAFKA-6813: Remove deprecated APIs in KIP-182, Part II (apache#4976) KAFKA-6878 Switch the order of underlying.init and initInternal (apache#4988) KAFKA-6299; Fix AdminClient error handling when metadata changes (apache#4295) KAFKA-6878: NPE when querying global state store not in READY state (apache#4978) KAFKA 6673: Implemented missing override equals method (apache#4745) KAFKA-6834: Handle compaction with batches bigger than max.message.bytes (apache#4953)
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Make `KafkaMetric.measurableValue` thread-safe Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see KAFKA-6870 for more details.
Committer Checklist (excluded from commit message)