Skip to content

MINOR: Increase timeout and add more context to error message#5840

Merged
mjsax merged 1 commit intoapache:1.0from
bbejeck:MINOR_increase_timeout_add_more_to_error_message
Oct 26, 2018
Merged

MINOR: Increase timeout and add more context to error message#5840
mjsax merged 1 commit intoapache:1.0from
bbejeck:MINOR_increase_timeout_add_more_to_error_message

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Oct 25, 2018

Increasing timeout in the test, added more context to the error message to help diagnose future failures

For testing, I ran the existing suite of streams tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 25, 2018

@mjsax @vvcephei

\cc @guozhangwang

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bbejeck !

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 25, 2018

retest this please

@mjsax mjsax merged commit 175a930 into apache:1.0 Oct 26, 2018
@bbejeck bbejeck deleted the MINOR_increase_timeout_add_more_to_error_message branch July 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants