MINOR: Increase low timeouts to help with test flakiness#5841
MINOR: Increase low timeouts to help with test flakiness#5841mjsax merged 3 commits intoapache:2.0from
Conversation
| return firstRecordProcessed; | ||
| } | ||
| }, 5000L, "Has not processed record within 5 seconds"); | ||
| }, "Has not processed record within 5 seconds"); |
There was a problem hiding this comment.
When no timeout is specified the default time of 15 seconds is used.
| return firstRecordProcessed; | ||
| } | ||
| }, 5000L, "Has not processed record within 5 seconds"); | ||
| }, "Has not processed record within 15 seconds"); |
There was a problem hiding this comment.
When not time specified for the timeout, 15 seconds is used by default
There was a problem hiding this comment.
Nit: what if the default changes :P
There was a problem hiding this comment.
With regard to #5840 -- should we set timeout to 30 seconds?
There was a problem hiding this comment.
Yeah I'll update this to have the same timeout as well cf #5843
|
retest this please |
|
updated this |
|
I lost a little track as you have other PR in parallel. This PR was for |
|
Seems #5843 covers |
|
Yes, the timeouts need to be adjusted in I intended to have #5843 cherry-picked into |
|
Thanks. Cherry-picked #5843 to |
3 participants
The
InternalTopicIntegrationTestandGlobalThreadShutDownOrderTestuse relatively strict timeouts of 5 seconds to check the intermediate state of the tests. The test failures observed in these two tests were not about the final output but asserting the embedded broker sent messages within the given timeframe.I ran the existing Streams test suite.
Committer Checklist (excluded from commit message)