Skip to content

MINOR: Bump timeout for sending records#5843

Merged
mjsax merged 3 commits intoapache:trunkfrom
bbejeck:MINOR_bump_timeout_for_sending_records
Oct 28, 2018
Merged

MINOR: Bump timeout for sending records#5843
mjsax merged 3 commits intoapache:trunkfrom
bbejeck:MINOR_bump_timeout_for_sending_records

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Oct 25, 2018

Set timeout to be consistent with changes to 2.0 #5841 when merged we should cherry-pick to 2.1

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 25, 2018

@mjsax @vvcephei

\cc @guozhangwang

vvcephei
vvcephei approved these changes Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @bbejeck !

mjsax
mjsax reviewed Oct 25, 2018
View reviewed changes
Comment thread streams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java Outdated
return firstRecordProcessed;
}
}, 10000L, "Has not processed record within 10 seconds");
}, "Has not processed record within 15 seconds");
Copy link
Copy Markdown
Member

@mjsax mjsax Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on the other PR. Should we increase to 30 seconds?

Copy link
Copy Markdown
Member Author

@bbejeck bbejeck Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree I'll update all related PRs to use a 30 second timeout

@bbejeck bbejeck mentioned this pull request Oct 26, 2018
Merged
3 tasks
@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 26, 2018

updated this

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 26, 2018

Java11: https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/302/

java.lang.RuntimeException: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout.
	at org.apache.kafka.streams.integration.utils.KafkaEmbedded.createTopic(KafkaEmbedded.java:185)
	at org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster.createTopic(EmbeddedKafkaCluster.java:196)
	at org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster.createTopics(EmbeddedKafkaCluster.java:160)
	at org.apache.kafka.streams.KafkaStreamsTest.shouldReturnFalseOnCloseWhenThreadsHaventTerminated(KafkaStreamsTest.java:442)

This seems to be new? \cc @vvcephei

4 more non-streams failures:

kafka.api.UserClientIdQuotaTest.testThrottledProducerConsumer
kafka.api.UserClientIdQuotaTest.testQuotaOverrideDelete
kafka.api.UserQuotaTest.testThrottledProducerConsumer
kafka.api.UserQuotaTest.testQuotaOverrideDelete

Retest this please.

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 27, 2018

Non related streams failure kafka.server.MetadataRequestTest.testAliveBrokersWithNoTopics

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 28, 2018

Java8 is green. Merging this.

@mjsax mjsax merged commit 63715ef into apache:trunk Oct 28, 2018
@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Oct 28, 2018

thanks @mjsax!

mjsax pushed a commit that referenced this pull request Nov 5, 2018
@bbejeck @mjsax
MINOR: Bump timeout for sending records (#5843)
3fb42f4 
Reviewers: John Roesler <john@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Nov 5, 2018

Cherry-picked to 2.1 branch.

pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@bbejeck @pengxiaolong
MINOR: Bump timeout for sending records (apache#5843)
7e427c8 
Reviewers: John Roesler <john@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@bbejeck bbejeck deleted the MINOR_bump_timeout_for_sending_records branch July 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjsax mjsax mjsax left review comments

@vvcephei vvcephei vvcephei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbejeck @mjsax @vvcephei