MINOR: updated documentation where RocksDBStore was being used as the…#5884
Merged
guozhangwang merged 3 commits intoapache:trunkfrom Feb 2, 2020
Merged
MINOR: updated documentation where RocksDBStore was being used as the…#5884guozhangwang merged 3 commits intoapache:trunkfrom
guozhangwang merged 3 commits intoapache:trunkfrom
Conversation
… sample class for byte[] versus Bytes examples
Member
|
ping @guozhangwang @mjsax @vvcephei @ableegoldman for a second review. |
Member
|
retest this please |
mjsax
reviewed
Feb 23, 2019
| @@ -36,7 +36,7 @@ | |||
| * | |||
| * * Note that the use of array-typed keys is discouraged because they result in incorrect ordering behavior. | |||
Member
There was a problem hiding this comment.
Can we fix this, too? Should not be * * Note... but * Note...
Member
|
@cfeduke This PR need to be rebased to resolve merge conflicts. There are also some open comments. |
Member
|
@cfeduke -- just cycling back to this PR -- can you update it to resolve the conflicts and address the review comments? |
andrewchoi5
approved these changes
Feb 2, 2020
Contributor
|
I've pushed a commit to resolve conflicts and merging now. Thanks @cfeduke for the patch! |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Feb 4, 2020
Conflicts related to version bump in AK, replaced 2.6 with 6.0: * gradle.properties * __init__.py * version.py * apache-github/trunk: KAFKA-9490: Fix generics for Grouped (apache#8028) Bump trunk to 2.6.0-SNAPSHOT (apache#8026) KAFKA-9027, KAFKA-9028: Convert create/delete acls requests/response to use generated protocol (apache#7725) MINOR: Refactor CheckpointFile to improve testability (apache#7391) MINOR: updated documentation where RocksDBStore was being used as the sample class for byte[] versus Bytes examples (apache#5884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… sample class for byte[] versus Bytes examples