MINOR: refactor CheckpointFile to improve testability#7391
Merged
ijuma merged 2 commits intoapache:trunkfrom Feb 3, 2020
Merged
MINOR: refactor CheckpointFile to improve testability#7391ijuma merged 2 commits intoapache:trunkfrom
ijuma merged 2 commits intoapache:trunkfrom
Conversation
Refactors CheckpointFile such that buffers can be read in lieu of files. This is a relatively simple change as we already create a buffered reader over the checkpoint file.
Contributor
|
Another git clone failure. Maybe we need to open an INFRA jira. |
Contributor
|
LGTM. Thanks, @lbradstreet . |
Contributor
Author
|
retest this please |
1 similar comment
Member
|
retest this please |
ijuma
reviewed
Oct 10, 2019
| @@ -85,36 +127,9 @@ class CheckpointFile[T](val file: File, | |||
| lock synchronized { | |||
Member
There was a problem hiding this comment.
Can we remove malformedLineException() in this method, it doesn't seem to be used anymore.
Contributor
Author
There was a problem hiding this comment.
Thanks, I've removed it.
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Feb 4, 2020
Conflicts related to version bump in AK, replaced 2.6 with 6.0: * gradle.properties * __init__.py * version.py * apache-github/trunk: KAFKA-9490: Fix generics for Grouped (apache#8028) Bump trunk to 2.6.0-SNAPSHOT (apache#8026) KAFKA-9027, KAFKA-9028: Convert create/delete acls requests/response to use generated protocol (apache#7725) MINOR: Refactor CheckpointFile to improve testability (apache#7391) MINOR: updated documentation where RocksDBStore was being used as the sample class for byte[] versus Bytes examples (apache#5884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors CheckpointFile such that buffers can be read in lieu of files. This is a relatively simple refactoring as we already create a buffered reader over the checkpoint file.
#6742, which improves the performance of the checkpointing code, requires a similar refactoring of code, although it does go further than this.