KAFKA-7389: Enable spotBugs with Java 11 and disable false positive warnings#5943
Merged
ijuma merged 1 commit intoapache:trunkfrom Nov 27, 2018
Merged
Conversation
Member
Author
|
@omkreddy can you please review this? |
3 tasks
…arnings See spotbugs/spotbugs#756 for details on the false positives affecting try with resources. An example is: RCN | Nullcheck of fc at line 629 of value previously dereferenced in org.apache.kafka.common.utils.Utils.readFileAsString(String, Charset)
ijuma
force-pushed
the
kafka-7389-spotbugs-java11
branch
from
042c78b to
04db4b6
Compare
ijuma
changed the title
omkreddy
approved these changes
Nov 27, 2018
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM
Member
Author
|
Cherry-picked to the 2.1 branch so that the Java 11 PR build can include spotbugs (the same PR build is used for both 2.1 and trunk). |
3 tasks
ijuma
added a commit
that referenced
this pull request
Nov 30, 2018
…arnings (#5943) See spotbugs/spotbugs#756 for details on the false positives affecting try with resources. An example is: > RCN | Nullcheck of fc at line 629 of value previously dereferenced in > org.apache.kafka.common.utils.Utils.readFileAsString(String, Charset) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…arnings (apache#5943) See spotbugs/spotbugs#756 for details on the false positives affecting try with resources. An example is: > RCN | Nullcheck of fc at line 629 of value previously dereferenced in > org.apache.kafka.common.utils.Utils.readFileAsString(String, Charset) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See spotbugs/spotbugs#756 for details on
the false positives affecting try with resources. An example is:
Committer Checklist (excluded from commit message)