MINOR: Update zstd, easymock, powermock, zkclient and build plugins#5846
Merged
ijuma merged 7 commits intoapache:trunkfrom Nov 10, 2018
Merged
MINOR: Update zstd, easymock, powermock, zkclient and build plugins#5846ijuma merged 7 commits intoapache:trunkfrom
ijuma merged 7 commits intoapache:trunkfrom
Conversation
ijuma
force-pushed
the
update-deps-2.2
branch
from
7cdc639 to
d27cdb4
Compare
ijuma
changed the title
Member
Author
|
Looks like there's a problem: |
ijuma
force-pushed
the
update-deps-2.2
branch
from
d27cdb4 to
7003e45
Compare
ijuma
force-pushed
the
update-deps-2.2
branch
from
ebcc053 to
8113808
Compare
ijuma
changed the title
ijuma
changed the title
Member
Author
|
@omkreddy Would you have time to review this PR? |
Member
Author
|
Hmm, seems like there are still some test failures. Let me look at those. |
ijuma
force-pushed
the
update-deps-2.2
branch
from
d937d59 to
b592884
Compare
omkreddy
approved these changes
Nov 10, 2018
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
LGTM. All tests are passing in local run.
Member
Author
|
JDK 8 build passed, JDK 11 had unrelated failures. Merging to trunk. |
Member
Author
|
Cherry-picked to the 2.1 branch so that we can run spotbugs with Java 11, see #5943 (comment) |
ijuma
added a commit
that referenced
this pull request
Nov 30, 2018
…5846) EasyMock 4.0.x includes a change that relies on the caller for inferring the return type of mock creator methods. Updated a number of Scala tests for compilation and execution to succeed. The versions of EasyMock and PowerMock in this PR include full support for Java 11. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…pache#5846) EasyMock 4.0.x includes a change that relies on the caller for inferring the return type of mock creator methods. Updated a number of Scala tests for compilation and execution to succeed. The versions of EasyMock and PowerMock in this PR include full support for Java 11. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EasyMock 4.0.x includes a change that relies on the caller for inferring
the return type of mock creator methods. Updated a number of Scala
tests for compilation and execution to succeed.
The versions of EasyMock and PowerMock in this PR include full support
for Java 11.
Committer Checklist (excluded from commit message)