Upgrade spotbugs, easymock, powermock#171
Merged
Xavier Léauté (xvrl) merged 1 commit intoconfluentinc:masterfrom Nov 12, 2018
xvrl:more-jdk11
Merged
Upgrade spotbugs, easymock, powermock#171Xavier Léauté (xvrl) merged 1 commit intoconfluentinc:masterfrom xvrl:more-jdk11
Xavier Léauté (xvrl) merged 1 commit intoconfluentinc:masterfrom
xvrl:more-jdk11
Conversation
Member
Xavier Léauté (xvrl)
commented
Nov 10, 2018
Xavier Léauté (xvrl)
commented
- spotbugs 3.1.8 fixes the issue we saw in Revert to SpotBugs 3.1.5 #169
- easymock 4.0.1 for JDK11 support
- powermock 2.0.0-rc3 for JDK11 support
Xavier Léauté (xvrl)
requested review from
Ewen Cheslack-Postava (ewencp) and
Ismael Juma (ijuma)
Member
|
There's one change in EasyMock that can cause compiler errors, did you run a build via muckrake? |
- spotbugs 3.1.8 fixes the issue we saw in #169 - easymock 4.0.1 for JDK11 support - powermock 2.0.0-rc3 for JDK11 support
Member
Author
|
Ismael Juma (@ijuma) what change are you referring to? muckrake is currently not working. |
Member
|
Xavier Léauté (@xvrl) See apache/kafka#5846 for example. Have you tried running |
Member
Author
|
Ismael Juma (@ijuma) I verified the build succeeds now that confluentinc/kafka-rest#509 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.