Merged
Conversation
Newer versions break when processing Kafka code. A couple of examples:
Error processing opcode checkcast @ 63 in kafka.security.auth.SimpleAclAuthorizer.logMessage$1 : (Lorg.apache.kafka.common.security.auth.KafkaPrincipal;ZLkafka.security.auth.Operation;Lkafka.security.auth.Resource;Ljava.lang.String;)Ljava.lang.String;
Error processing opcode checkcast @ 31 in kafka.cluster.Broker.toString : ()Ljava.lang.String;
java.lang.IllegalArgumentException: Unknown signature [Ljava/lang/Object; for number 4
At edu.umd.cs.findbugs.OpcodeStack$Item.<init>(OpcodeStack.java:671)
Ismael Juma (ijuma)
requested review from
Ewen Cheslack-Postava (ewencp) and
Xavier Léauté (xvrl)
Xavier Léauté (xvrl)
approved these changes
Oct 21, 2018
Ismael Juma (ijuma)
added a commit
that referenced
this pull request
Oct 21, 2018
* origin/5.1.x: Revert to SpotBugs 3.1.5 (#169)
Xavier Léauté (xvrl)
added a commit
that referenced
this pull request
Nov 12, 2018
- spotbugs 3.1.8 fixes the issue we saw in #169 - easymock 4.0.1 for JDK11 support - powermock 2.0.0-rc3 for JDK11 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions break when processing Kafka code. A couple of examples: