Skip to content

fix ProducerPerformance bug when numRecords > Integer.MAX, it will fa…#5956

Merged
omkreddy merged 1 commit intoapache:trunkfrom
seayoun:trunk
Nov 29, 2018
Merged

fix ProducerPerformance bug when numRecords > Integer.MAX, it will fa…#5956
omkreddy merged 1 commit intoapache:trunkfrom
seayoun:trunk

Conversation

@seayoun
Copy link
Copy Markdown
Contributor

@seayoun seayoun commented Nov 28, 2018

…ll into non-stop loop and send more message to broker, and Stat in PerfCallback method record will throw ArrayIndexOutOfBoundsException

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…ll into non-stop loop and send more message to broker, and Stat in PerfCallback method record will throw ArrayIndexOutOfBoundsException
Copy link
Copy Markdown
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seayoun Thanks for the PR. Good Catch!

@seayoun seayoun closed this Nov 29, 2018
@seayoun seayoun reopened this Nov 29, 2018
@omkreddy omkreddy merged commit 4fb5520 into apache:trunk Nov 29, 2018
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…che#5956)

Current code will fall into non-stop loop and send more message to broker, and Stat in PerfCallback method record will throw ArrayIndexOutOfBoundsException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants