Skip to content

create topic disk allocate strategy per broker#5970

Closed
seayoun wants to merge 2 commits intoapache:trunkfrom
seayoun:trunk
Closed

create topic disk allocate strategy per broker#5970
seayoun wants to merge 2 commits intoapache:trunkfrom
seayoun:trunk

Conversation

@seayoun
Copy link
Copy Markdown
Contributor

@seayoun seayoun commented Nov 29, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…ll into non-stop loop and send more message to broker, and Stat in PerfCallback method record will throw ArrayIndexOutOfBoundsException
… partition count in each directory and then count by total partitions in each directory; first consider is topic level balance, because topic flow is not equal , such huge flow and small flow
@seayoun seayoun closed this Nov 30, 2018
@seayoun seayoun reopened this Nov 30, 2018
@kaushiksrinivas
Copy link
Copy Markdown

retest this please.

int currentTransactionSize = 0;
long transactionStartTime = 0;
for (int i = 0; i < numRecords; i++) {
for (long i = 0; i < numRecords; i++) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already merged this change as part of #5956

@omkreddy
Copy link
Copy Markdown
Contributor

omkreddy commented Nov 30, 2018

@seayoun Request you to create a JIRA and describe the requirement/change. This will be useful to understand/track the changes.
https://issues.apache.org/jira/projects/KAFKA/

@seayoun
Copy link
Copy Markdown
Contributor Author

seayoun commented Nov 30, 2018

ok, thank you

@seayoun
Copy link
Copy Markdown
Contributor Author

seayoun commented Nov 30, 2018

@seayoun Request you to create a JIRA and describe the requirement/change. This will be useful to understand/track the changes.
https://issues.apache.org/jira/projects/KAFKA/

I submit an issue on jira https://issues.apache.org/jira/browse/KAFKA-7690 , I am Looking forward to your suggestions.

@seayoun
Copy link
Copy Markdown
Contributor Author

seayoun commented Nov 30, 2018

retest this please.

discuss here https://issues.apache.org/jira/browse/KAFKA-7690

@github-actions
Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Nov 21, 2024
@github-actions
Copy link
Copy Markdown

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions Bot added the closed-stale PRs that were closed due to inactivity label Dec 22, 2024
@github-actions github-actions Bot closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants