MINOR: Fix failing test in ConsumeBenchTest:test_multiple_consumers_specifie…#6015
Merged
ijuma merged 2 commits intoapache:trunkfrom Dec 8, 2018
stanislavkozlovski:patch-1
Merged
MINOR: Fix failing test in ConsumeBenchTest:test_multiple_consumers_specifie…#6015ijuma merged 2 commits intoapache:trunkfrom stanislavkozlovski:patch-1
ijuma merged 2 commits intoapache:trunkfrom
stanislavkozlovski:patch-1
Conversation
…d_group_partitions_should_raise This test apparently never passed. The problem is that during the review of the Pull Request we forgot to update the test.
Contributor
Author
|
cc @cmccabe |
ijuma
reviewed
Dec 8, 2018
| Runs multiple consumers in the same group to read messages from specific partitions. | ||
| It is an invalid configuration to provide a consumer group and specific partitions. | ||
| """ | ||
| expected_error_msg = 'You may not specify an explicit partition assignment when using multiple consumers in the same group' |
Member
There was a problem hiding this comment.
Maybe we should only look for "explicit partition assignment" in the message.
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…_group_partitions_should_raise (apache#6015) This is the error message we're after: "You may not specify an explicit partition assignment when using multiple consumers in the same group." We apparently changed it midway through apache#5810 and forgot to update the test. Reviewers: Dhruvil Shah <dhruvil@confluent.io>, Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the error message we're after:
kafka/tools/src/main/java/org/apache/kafka/trogdor/workload/ConsumeBenchWorker.java
Line 120 in c050503
We apparently changed it midway through #5810 and forgot to update the test