Skip to content

MINOR: Fix failing test in ConsumeBenchTest:test_multiple_consumers_specifie… #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 2 commits into from
Dec 8, 2018
Merged

MINOR: Fix failing test in ConsumeBenchTest:test_multiple_consumers_specifie… #6015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a41a0f
Fix failing test in ConsumeBenchTest:test_multiple_consumers_specifie…
stanislavkozlovski Dec 7, 2018
d23f608
Use shorter error message
stanislavkozlovski Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/kafkatest/tests/core/consume_bench_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,10 @@ def test_multiple_consumers_random_group_partitions(self):

def test_multiple_consumers_specified_group_partitions_should_raise(self):
"""
Runs multiple consumers in to read messages from specific partitions.
Since a consumerGroup isn't specified, each consumer will get assigned a random group
and consume from all partitions
Runs multiple consumers in the same group to read messages from specific partitions.
It is an invalid configuration to provide a consumer group and specific partitions.
"""
expected_error_msg = 'explicit partition assignment'
self.produce_messages(self.active_topics, max_messages=20000)
consume_spec = ConsumeBenchWorkloadSpec(0, TaskSpec.MAX_DURATION_MS,
self.consumer_workload_service.consumer_node,
Expand All @@ -198,7 +198,7 @@ def test_multiple_consumers_specified_group_partitions_should_raise(self):
consume_workload.wait_for_done(timeout_sec=360)
raise Exception("Should have raised an exception due to an invalid configuration")
except RuntimeError as e:
if 'Will not split partitions' not in str(e):
if expected_error_msg not in str(e):
raise RuntimeError("Unexpected Exception - " + str(e))
self.logger.info(e)