KAFKA-7839 Add quotes to CLASSPATH on Java start#6166
Closed
rwunderer wants to merge 3 commits intoapache:trunkfrom
Closed
KAFKA-7839 Add quotes to CLASSPATH on Java start#6166rwunderer wants to merge 3 commits intoapache:trunkfrom
rwunderer wants to merge 3 commits intoapache:trunkfrom
Conversation
|
Also see #4469 |
vvcephei
approved these changes
Dec 16, 2019
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
Maybe we can get a review from someone who has spent a bit more time with this script.
| # Syntax used on the right side is native Bash string manipulation; for more details see | ||
| # http://tldp.org/LDP/abs/html/string-manipulation.html, specifically the section titled "Substring Removal" | ||
| CLASSPATH=${CLASSPATH#:} | ||
| CLASSPATH="${CLASSPATH#:}" |
Contributor
There was a problem hiding this comment.
I don't think this is harmful, but it's also not strictly necessary here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing quotes around CLASSPATH break kafka-run-class.sh when CLASSPATH contains only a single component with wildcards. For detailed description of the problem see Jira ticket.
This (trivial) contribution is my original work and I license it to the project under the project's open source license.