Skip to content

KAFKA-7839 Add quotes to CLASSPATH on Java start #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwunderer wants to merge 3 commits into from
Closed

KAFKA-7839 Add quotes to CLASSPATH on Java start #6166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe4c63b
KAFKA-7839 Add quotes to CLASSPATH on Java start
rwunderer Jan 18, 2019
1c73eb8
Merge branch 'trunk' into KAFKA-7839_Add_quotes_to_CLASSPATH_when_sta…
rwunderer Dec 16, 2019
9dde33a
Merge branch 'trunk' into KAFKA-7839_Add_quotes_to_CLASSPATH_when_sta…
rwunderer Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/kafka-run-class.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ fi
# Remove a possible colon prefix from the classpath (happens at lines like `CLASSPATH="$CLASSPATH:$file"` when CLASSPATH is blank)
# Syntax used on the right side is native Bash string manipulation; for more details see
# http://tldp.org/LDP/abs/html/string-manipulation.html, specifically the section titled "Substring Removal"
CLASSPATH=${CLASSPATH#:}
CLASSPATH="${CLASSPATH#:}"
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is harmful, but it's also not strictly necessary here.


# If Cygwin is detected, classpath is converted to Windows format.
(( WINDOWS_OS_FORMAT )) && CLASSPATH=$(cygpath --path --mixed "${CLASSPATH}")
Expand Down