MINOR: increase timeouts for KafkaStreamsTest#6178
Merged
mjsax merged 2 commits intoapache:trunkfrom Jan 21, 2019
Merged
Conversation
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @ijuma |
wicknicks
reviewed
Jan 20, 2019
Contributor
There was a problem hiding this comment.
nit: make a constant for this value? helps to read and understand the time unit.
Member
Author
|
Updated per review comment. |
mjsax
force-pushed
the
minor-increase-timeout-kafkastreamstest
branch
from
7c28482 to
eae600b
Compare
Member
Author
|
Rebased to pick up test fix for connect. |
|
Sorry what's the purpose of extending timeout here? Are there flakey tests? |
Member
Author
|
Yes, we saw some test failures hitting those timeouts. We hope to stabilize the Jenkins build with this. |
Member
|
Btw, have we only seen the failures with Java 8? |
Member
Author
|
I am not sure. Jenkins is green. I am going to merge this now. |
Member
|
Hmm, did you get any committer review? |
Member
|
The reason I asked is twofold:
|
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
Jan 24, 2019
Reviewer: Arjun Satish <arjun@confluent.io>
Member
Author
Member
|
Thanks @mjsax. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* ak/trunk: MINOR: fix race condition in KafkaStreamsTest (apache#6185) KAFKA-4850: Enable bloomfilters (apache#6012) MINOR: ducker-ak: add down -f, avoid using a terminal in ducker test KAFKA-5117: Stop resolving externalized configs in Connect REST API MINOR: Cleanup handling of mixed transactional/idempotent records (apache#6172) KAFKA-7844: Use regular subproject for generator to fix *All targets (apache#6182) Fix Documentation for cleanup.policy is out of date (apache#6181) MINOR: increase timeouts for KafkaStreamsTest (apache#6178) MINOR: Rejoin split ssl principal mapping rules (apache#6099) MINOR: Handle case where connector status endpoints returns 404 (apache#6176) MINOR: Remove unused imports, exceptions, and values (apache#6117) KAFKA-3522: Add internal RecordConverter interface (apache#6150) Fix Javadoc of KafkaConsumer (apache#6155) KAFKA-6455: Extend CacheFlushListener to forward timestamp (apache#6147) MINOR: Log partition info when creating new request batch in controller (apache#6145) KAFKA-7652: Part I; Fix SessionStore's findSession(single-key) (apache#6134) MINOR: Remove the InvalidTopicException handling in InternalTopicManager (apache#6167) [KAFKA-7024] Rocksdb state directory should be created before opening the DB (apache#6138) MINOR:: Fix typos (apache#6079)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewer: Arjun Satish <arjun@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.