Skip to content

KAFKA-7840: Documentation for cleanup.policy is out of date#6181

Merged
vahidhashemian merged 1 commit intoapache:trunkfrom
dongjinleekr:feature/KAFKA-7840
Jan 21, 2019
Merged

KAFKA-7840: Documentation for cleanup.policy is out of date#6181
vahidhashemian merged 1 commit intoapache:trunkfrom
dongjinleekr:feature/KAFKA-7840

Conversation

@dongjinleekr
Copy link
Copy Markdown
Contributor

A trivial documentation fix.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Contributor

@vahidhashemian vahidhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update!

@vahidhashemian vahidhashemian merged commit 07d2cf2 into apache:trunk Jan 21, 2019
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 22, 2019

Might be worth to cherry-pick to older branches? Basically back to 0.10.1 when the feature was introduced?

Should we get a PR against kafka-site, too, to update the docs immediately? Otherwise this will only be reflected when we roll a new release.

@dongjinleekr
Copy link
Copy Markdown
Contributor Author

@mjsax Sure. I shall do it ASAP.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 22, 2019

I don't think it's worth backporting all the way to 0.10.1. That release is more than 2 years old.

abbccdda pushed a commit to abbccdda/kafka that referenced this pull request Jan 24, 2019
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* ak/trunk:
  MINOR: fix race condition in KafkaStreamsTest (apache#6185)
  KAFKA-4850: Enable bloomfilters (apache#6012)
  MINOR: ducker-ak: add down -f, avoid using a terminal in ducker test
  KAFKA-5117: Stop resolving externalized configs in Connect REST API
  MINOR: Cleanup handling of mixed transactional/idempotent records (apache#6172)
  KAFKA-7844: Use regular subproject for generator to fix *All targets (apache#6182)
  Fix Documentation for cleanup.policy is out of date (apache#6181)
  MINOR: increase timeouts for KafkaStreamsTest (apache#6178)
  MINOR: Rejoin split ssl principal mapping rules (apache#6099)
  MINOR: Handle case where connector status endpoints returns 404 (apache#6176)
  MINOR: Remove unused imports, exceptions, and values (apache#6117)
  KAFKA-3522: Add internal RecordConverter interface (apache#6150)
  Fix Javadoc of KafkaConsumer (apache#6155)
  KAFKA-6455: Extend CacheFlushListener to forward timestamp (apache#6147)
  MINOR: Log partition info when creating new request batch in controller (apache#6145)
  KAFKA-7652: Part I; Fix SessionStore's findSession(single-key) (apache#6134)
  MINOR: Remove the InvalidTopicException handling in InternalTopicManager (apache#6167)
  [KAFKA-7024] Rocksdb state directory should be created before opening the DB (apache#6138)
  MINOR:: Fix typos (apache#6079)
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants