MINOR: Fix bugs identified by compiler warnings#6258
Merged
ijuma merged 10 commits intoapache:trunkfrom Feb 15, 2019
Merged
Conversation
ijuma
commented
Feb 12, 2019
Member
Author
There was a problem hiding this comment.
@tombentley Please check that we didn't intend to use this.
Contributor
There was a problem hiding this comment.
Yes, this can be removed since the logic is folded into onComplete() already.
ijuma
commented
Feb 12, 2019
ijuma
commented
Feb 12, 2019
Member
Author
There was a problem hiding this comment.
@tombentley after I fixed this, the test started failing. return was causing everything after this not to run. Can you please check what the issue is and fix it? cc @mjsax in case this is a regression and not a test problem.
Contributor
There was a problem hiding this comment.
@ijuma : Good find. These are indeed existing bugs. There are 4 references of LeaderNotAvailableException in line 1358, 1372, 1380 and 1390. They all need to be changed to PreferredLeaderNotAvailableException. Once I fixed those locally, the test passes.
ijuma
force-pushed
the
fix-compiler-warnings
branch
from
c6c610d to
f2b655d
Compare
Member
Author
|
@junrao I pushed a fix for the failing test and minor tweaks. Let me know if this looks good to you. |
Member
Author
|
Merged to trunk and cherry-picked to 2.2. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* ak/trunk: (45 commits) KAFKA-7487: DumpLogSegments misreports offset mismatches (apache#5756) MINOR: improve JavaDocs about auto-repartitioning in Streams DSL (apache#6269) KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None (apache#6274) KAFKA-7895: Fix stream-time reckoning for suppress (apache#6278) KAFKA-6569: Move OffsetIndex/TimeIndex logger to companion object (apache#4586) MINOR: add log indicating the suppression time (apache#6260) MINOR: Make info logs for KafkaConsumer a bit more verbose (apache#6279) KAFKA-7758: Reuse KGroupedStream/KGroupedTable with named repartition topics (apache#6265) KAFKA-7884; Docs for message.format.version should display valid values (apache#6209) MINOR: Save failed test output to build output directory MINOR: add test for StreamsSmokeTestDriver (apache#6231) MINOR: Fix bugs identified by compiler warnings (apache#6258) KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 4] (apache#5433) MINOR: fix bypasses in ChangeLogging stores (apache#6266) MINOR: Make MockClient#poll() more thread-safe (apache#5942) MINOR: drop dbAccessor reference on close (apache#6254) KAFKA-7811: Avoid unnecessary lock acquire when KafkaConsumer commits offsets (apache#6119) KAFKA-7916: Unify store wrapping code for clarity (apache#6255) MINOR: Add missing Alter Operation to Topic supported operations list in AclCommand KAFKA-7921: log at error level for missing source topic (apache#6262) ...
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
- Add missing string interpolation - Fix and simplify testElectPreferredLeaders - Remove unused code - Replace deprecated usage of JUnit `assertThat` - Change var to val and fix non-exhaustive pattern match - Fix eta warning - Simplify code - Remove commented out code Reviewers: Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertThatCommitter Checklist (excluded from commit message)