Skip to content

KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None#6274

Merged
rajinisivaram merged 2 commits intoapache:trunkfrom
ijuma:fix-unsupported-compression-type-error
Feb 18, 2019
Merged

KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None#6274
rajinisivaram merged 2 commits intoapache:trunkfrom
ijuma:fix-unsupported-compression-type-error

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Feb 15, 2019 •
edited
Loading

Replace forall with exists.

Added a unit test to KafkaApisTest that failed before the change.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma changed the title MINOR: Fix check that triggers UnsupportedCompressonType exception KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None Feb 17, 2019
@ijuma ijuma force-pushed the fix-unsupported-compression-type-error branch from 828de44 to 6c9181b Compare February 17, 2019 11:23
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Feb 18, 2019

JDK 11 test passed, JDK 8 failed with unrelated:

org.scalatest.junit.JUnitTestFailedError: Should have received an class org.apache.kafka.common.errors.GroupMaxSizeReachedException during the cluster roll
	at org.scalatest.junit.AssertionsForJUnit$class.newAssertionFailedException(AssertionsForJUnit.scala:100)
	at org.scalatest.junit.JUnitSuite.newAssertionFailedException(JUnitSuite.scala:71)
	at org.scalatest.Assertions$class.fail(Assertions.scala:1089)
	at org.scalatest.junit.JUnitSuite.fail(JUnitSuite.scala:71)
	at kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup(ConsumerBounceTest.scala:376)

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Feb 18, 2019

retest this please

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Feb 18, 2019

JDK 11 build passed, JDK 8 build timed out:

02:44:29 org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest > shouldForwardAllDbOptionsCalls STARTED
06:30:03 Build timed out (after 240 minutes). Marking the build as aborted.
06:30:03 Build was aborted

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Feb 18, 2019

retest this please

@ijuma ijuma requested a review from hachikuji February 18, 2019 08:11
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Feb 18, 2019 •
edited
Loading

JDK 11 build passed, JDK 8 build failed with unrelated failure.

kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for connection while in state: CONNECTING
	at kafka.zookeeper.ZooKeeperClient.$anonfun$waitUntilConnected$3(ZooKeeperClient.scala:242)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:253)
	at kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:238)
	at kafka.zookeeper.ZooKeeperClient.<init>(ZooKeeperClient.scala:96)
	at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1825)
	at kafka.server.KafkaServer.createZkClient$1(KafkaServer.scala:361)
	at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:385)
	at kafka.server.KafkaServer.startup(KafkaServer.scala:205)
	at kafka.utils.TestUtils$.createServer(TestUtils.scala:135)
	at kafka.utils.TestUtils.createServer(TestUtils.scala)
	at org.apache.kafka.connect.util.clusters.EmbeddedKafkaCluster.start(EmbeddedKafkaCluster.java:125)

@ijuma ijuma requested review from rajinisivaram and removed request for hachikuji February 18, 2019 17:40
rajinisivaram
rajinisivaram approved these changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma Thanks for the PR, LGTM

@rajinisivaram
Copy link
Copy Markdown
Contributor

rajinisivaram commented Feb 18, 2019

Merging to trunk, 2.2 and 2.1

@rajinisivaram rajinisivaram merged commit 45a896e into apache:trunk Feb 18, 2019
rajinisivaram pushed a commit that referenced this pull request Feb 18, 2019
@ijuma @rajinisivaram
KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConf…
aa4907a 
…ig returns None (#6274)

Replaced `forall` with `exists`. Added a unit test to `KafkaApisTest` that failed before the change.

Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
rajinisivaram pushed a commit that referenced this pull request Feb 18, 2019
@ijuma @rajinisivaram
KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConf…
b65f5ce 
…ig returns None (#6274)

Replaced `forall` with `exists`. Added a unit test to `KafkaApisTest` that failed before the change.

Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
@lbradstreet
Merge remote-tracking branch 'ak/trunk' into cos-trunk
0eacf48 
* ak/trunk: (45 commits)
  KAFKA-7487: DumpLogSegments misreports offset mismatches (apache#5756)
  MINOR: improve JavaDocs about auto-repartitioning in Streams DSL (apache#6269)
  KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None (apache#6274)
  KAFKA-7895: Fix stream-time reckoning for suppress (apache#6278)
  KAFKA-6569: Move OffsetIndex/TimeIndex logger to companion object  (apache#4586)
  MINOR: add log indicating the suppression time (apache#6260)
  MINOR: Make info logs for KafkaConsumer a bit more verbose (apache#6279)
  KAFKA-7758: Reuse KGroupedStream/KGroupedTable with named repartition topics (apache#6265)
  KAFKA-7884; Docs for message.format.version should display valid values (apache#6209)
  MINOR: Save failed test output to build output directory
  MINOR: add test for StreamsSmokeTestDriver (apache#6231)
  MINOR: Fix bugs identified by compiler warnings (apache#6258)
  KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 4] (apache#5433)
  MINOR: fix bypasses in ChangeLogging stores (apache#6266)
  MINOR: Make MockClient#poll() more thread-safe (apache#5942)
  MINOR: drop dbAccessor reference on close (apache#6254)
  KAFKA-7811: Avoid unnecessary lock acquire when KafkaConsumer commits offsets (apache#6119)
  KAFKA-7916: Unify store wrapping code for clarity (apache#6255)
  MINOR: Add missing Alter Operation to Topic supported operations list in AclCommand
  KAFKA-7921: log at error level for missing source topic (apache#6262)
  ...
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@ijuma @pengxiaolong
KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConf…
8868026 
…ig returns None (apache#6274)

Replaced `forall` with `exists`. Added a unit test to `KafkaApisTest` that failed before the change.

Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajinisivaram rajinisivaram rajinisivaram approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijuma @rajinisivaram