Conversation
|
|
||
| dev_branch = '.'.join(release_version_parts[:2]) | ||
| docs_release_version = docs_version(release_version[:2]) | ||
| docs_release_version = docs_version(release_version) |
There was a problem hiding this comment.
Comparing with https://github.com/apache/kafka/pull/6317/files#diff-97f2783dc2d2b4c99fad05f863e53686R216
It seems we need to pass in the full version string, eg, 2.2.0 -- I run the script and in computed 2 as result instead of 22
There was a problem hiding this comment.
yeah, seems valid. we already chop off whatever we don't need in docs_version, I guess just leftover from the 0. days...
|
|
||
| dev_branch = '.'.join(release_version_parts[:2]) | ||
| docs_release_version = docs_version(release_version[:2]) | ||
| docs_release_version = docs_version(release_version) |
There was a problem hiding this comment.
yeah, seems valid. we already chop off whatever we don't need in docs_version, I guess just leftover from the 0. days...
|
oh, and re: which branches to port to, i think most people assume release mgr will run the script from trunk even if they are releasing something older. if that's not a good assumption, we should probably update the release instructions on the wiki to clarify |
Not sure what other people do. But if I work on |
|
Tests failed but are not available any longer. We know that |
Reviewer: Ewen Cheslack-Postava <ewen@confluent.io>
|
Merged to |
|
sure, if that's the case then it makes sense to backport more aggressively. we could easily still be doing updates back to, e.g., 1.0 or possibly even earlier. |
* apache/trunk: KAFKA-7880:Naming worker thread by task id (apache#6275) improve some logging statements (apache#6078) KAFKA-7312: Change broker port used in testMinimumRequestTimeouts and testForceClose KAFKA-7997: Use automatic RPC generation in SaslAuthenticate KAFKA-8002; Log dir reassignment stalls if future replica has different segment base offset (apache#6346) KAFKA-3522: Add TimestampedKeyValueStore builder/runtime classes (apache#6152) HOTFIX: add igore import to streams_upgrade_test MINOR: ConsumerNetworkClient does not need to send the remaining requests when the node is not ready (apache#6264) KAFKA-7922: Return authorized operations in describe consumer group responses (KIP-430 Part-1) KAFKA-7918: Inline generic parameters Pt. III: in-memory window store (apache#6328) KAFKA-8012; Ensure partitionStates have not been removed before truncating. (apache#6333) KAFKA-8011: Fix for race condition causing concurrent modification exception (apache#6338) KAFKA-7912: Support concurrent access in InMemoryKeyValueStore (apache#6336) MINOR: Skip quota check when replica is in sync (apache#6344) HOTFIX: Change header back to http instead of https to path license header test (apache#6347) MINOR: fix release.py script (apache#6317) MINOR: Remove types from caching stores (apache#6331) MINOR: Improve logging for alter log dirs (apache#6302) MINOR: state.cleanup.delay.ms default is 600,000 ms (10 minutes). (apache#6345) MINOR: disable Streams system test for broker upgrade/downgrade (apache#6341)
Reviewer: Ewen Cheslack-Postava <ewen@confluent.io>
2 participants
release.pydoes not compute docs-version string correctly.We should use
httpsinstead ofhttpin links.This should to into
2.2branch, too