KAFKA-7918: Inline generic parameters Pt. III: in-memory window store#6328
Merged
guozhangwang merged 2 commits intoapache:trunkfrom Mar 1, 2019
Merged
Conversation
Member
Author
bbejeck
reviewed
Feb 26, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
LGTM just a couple of minor formatting comments.
| @Deprecated | ||
| @Override | ||
| public KeyValueIterator<Windowed<K>, V> fetch(final K from, final K to, final long timeFrom, final long timeTo) { | ||
| public KeyValueIterator<Windowed<Bytes>, byte[]> fetch(final Bytes from, final Bytes to, final long timeFrom, final long timeTo) { |
Member
There was a problem hiding this comment.
nit: parameters on a separate line
|
|
||
| private KeyValue<Windowed<K>, V> getWindowedKeyValue(final K key, final long startTimestamp, final V value) { | ||
| final Windowed<K> windowedK = new Windowed<>(key, new TimeWindow(startTimestamp, startTimestamp + windowSize)); | ||
| private KeyValue<Windowed<Bytes>, byte[]> getWindowedKeyValue(final Bytes key, final long startTimestamp, final byte[] value) { |
Member
There was a problem hiding this comment.
nit: parameters on a separate line
3 tasks
Member
Author
|
JDK 11 failed on kafka.api.PlaintextConsumerTest.testAutoCommitIntercept Failures unrelated. Retest this, please |
Member
|
Java 11 passed, Java 8 failure unrelated retest this please |
Member
|
Java 11 passed, retest this please |
guozhangwang
approved these changes
Mar 1, 2019
Contributor
|
The jenkins machine seems failed. I've ran the tests locally and they pass, will merge now. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: KAFKA-7880:Naming worker thread by task id (apache#6275) improve some logging statements (apache#6078) KAFKA-7312: Change broker port used in testMinimumRequestTimeouts and testForceClose KAFKA-7997: Use automatic RPC generation in SaslAuthenticate KAFKA-8002; Log dir reassignment stalls if future replica has different segment base offset (apache#6346) KAFKA-3522: Add TimestampedKeyValueStore builder/runtime classes (apache#6152) HOTFIX: add igore import to streams_upgrade_test MINOR: ConsumerNetworkClient does not need to send the remaining requests when the node is not ready (apache#6264) KAFKA-7922: Return authorized operations in describe consumer group responses (KIP-430 Part-1) KAFKA-7918: Inline generic parameters Pt. III: in-memory window store (apache#6328) KAFKA-8012; Ensure partitionStates have not been removed before truncating. (apache#6333) KAFKA-8011: Fix for race condition causing concurrent modification exception (apache#6338) KAFKA-7912: Support concurrent access in InMemoryKeyValueStore (apache#6336) MINOR: Skip quota check when replica is in sync (apache#6344) HOTFIX: Change header back to http instead of https to path license header test (apache#6347) MINOR: fix release.py script (apache#6317) MINOR: Remove types from caching stores (apache#6331) MINOR: Improve logging for alter log dirs (apache#6302) MINOR: state.cleanup.delay.ms default is 600,000 ms (10 minutes). (apache#6345) MINOR: disable Streams system test for broker upgrade/downgrade (apache#6341)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…apache#6328) Third (and final) PR in series to inline the generic parameters of the following bytes stores: [Pt. I] InMemoryKeyValueStore [Pt. II] RocksDBWindowStore [Pt. II] RocksDBSessionStore [Pt. II] MemoryLRUCache [Pt. II] MemoryNavigableLRUCache [x] InMemoryWindowStore Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third (and final) PR in series to inline the generic parameters of the following bytes stores:
[Pt. I] InMemoryKeyValueStore
[Pt. II] RocksDBWindowStore
[Pt. II] RocksDBSessionStore
[Pt. II] MemoryLRUCache
[Pt. II] MemoryNavigableLRUCache
[x] InMemoryWindowStore
Committer Checklist (excluded from commit message)