MINOR: gradle and gradle plugins version upgrades

[dejan2609]

details:

• gradle: 5.1.1 -->> 5.2.1
• grgit: 1.9.3 -->> 3.0.0 (breaking change release, 'Grgit.open' usage is refactored)
• gradle-scoverage: 2.5.0 -->> 3.0.0 (opted out, see comments below)
• shadow: 4.0.3 -->> 4.0.4
• spotless-plugin-gradle: 3.17.0 -->> 3.18.0 (opted out, see comments below)
• spotbugs-gradle-plugin: 1.6.9 -->> 1.6.10

related links:

• https://github.com/gradle/gradle/releases/tag/v5.2.0, https://github.com/gradle/gradle/releases/tag/v5.2.1
• https://github.com/ajoberstar/grgit/releases/tag/3.0.0
• https://github.com/scoverage/gradle-scoverage/releases/tag/3.0.0
• https://github.com/johnrengelman/shadow/releases/tag/4.0.4
• https://github.com/diffplug/spotless/blob/gradle/3.18.0/CHANGES.md
• https://github.com/spotbugs/spotbugs-gradle-plugin/blob/1.6.10/CHANGELOG.md#1610---2019-02-18

[dejan2609]

Committer Checklist

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[dejan2609]

Both Jenkins jobs failed with this message: FAILURE No test results found.

Reason: Jenkins job setup phase is using Gradle 4.10.2 and that Gradle version is unsupported by a spotbugs-gradle-plugin version 1.6.10:
https://github.com/spotbugs/spotbugs-gradle-plugin/blob/1.6.10/CHANGELOG.md#1610---2019-02-18

22:42:44 Setting GRADLE_4_10_2_HOME=/home/jenkins/tools/gradle/4.10.2
22:42:44 [kafka-pr-jdk11-scala2.12] $ /bin/bash -xe /tmp/jenkins5613406374589745135.sh
22:42:44 + rm -rf /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/.gradle
22:42:44 + /home/jenkins/tools/gradle/4.10.2/bin/gradle
22:42:45 To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.10.2/userguide/gradle_daemon.html.
22:42:47 Daemon will be stopped at the end of the build stopping after processing
22:42:58 
22:42:58 FAILURE: Build failed with an exception.
22:42:58 
22:42:58 * Where:
22:42:58 Build file '/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/build.gradle' line: 155
22:42:58 
22:42:58 * What went wrong:
22:42:58 A problem occurred evaluating root project 'kafka-pr-jdk11-scala2.12'.
22:42:58 > Failed to apply plugin [id 'com.github.spotbugs']
22:42:58    > Gradle version Gradle 4.10.2 is unsupported. Please use Gradle 5.0 or later.

[dejan2609]

FIY @ijuma and @ewencp

[dejan2609]

Related JIRA ticket created here:
https://issues.apache.org/jira/browse/KAFKA-8009 Uppgrade Jenkins job Gradle version from 4.10.2 to 5.x

[ewencp]

Couple of comments. Regarding gradle 4.10.2 incompatibility, we'd need to work with apache infra to get a newer gradle version support. Just did a quick look at one of the PR jobs, but afaict we're already on the latest gradle version that builds.apache.org provides. To move to a 5.0+ version, we'd need upstream Apache infra to provide it on the Jenkins workers.

[dejan2609]

@ewencp additional commit pushed (it will be squashed/rebased eventually).

1. spotbugs-gradle-plugin version upgrade is removed (because recent plugin version requires Gradle 5+ on builds.apache.org Jenkins)
2. related to 'Grgit.open': I delved into, herewith a solution: Grgit.open(currentDir: project.getRootDir())
   Note: dir can be used also, but I prefer currentDir:

• http://ajoberstar.org/grgit/grgit-open.html
• https://github.com/ajoberstar/grgit/blob/3.0.0/grgit-core/src/main/groovy/org/ajoberstar/grgit/operation/OpenOp.groovy#L20

3. (update, see comments below) gradle-scoverage version upgrade is also opted-out (same reason as for spotbugs-gradle-plugin: Gradle 5+ is required on Jenkins)

[dejan2609]

Sigh 😞 similar issues on builds.apache.org Jenkins, this time with scoverage plugin.

@ewencp sorry for additional noise, I will test locally with Gradle 4.10.2

09:15:04 > Configure project :
09:15:04 Building project 'core' with Scala version 2.12.8
09:15:04 
09:15:04 FAILURE: Build failed with an exception.
09:15:04 
09:15:04 * Where:
09:15:04 Build file '/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.11/build.gradle' line: 635
09:15:04 
09:15:04 * What went wrong:
09:15:04 A problem occurred evaluating root project 'kafka-pr-jdk8-scala2.11'.
09:15:04 > Failed to apply plugin [id 'org.scoverage']
09:15:04    > Could not create task of type 'OverallCheckTask'.

[dejan2609]

@ewencp all checks have passed, please review again.

[dejan2609]

Closed in favor of #6436
Rationale: two weeks passed since last activity here, so I opted to include few more updates using brand new pull request.