Skip to content

MINOR: gradle-related version upgrades#6436

Merged
ijuma merged 1 commit intoapache:trunkfrom
dejan2609:gradle-related-version-upgrades
Apr 29, 2019
Merged

MINOR: gradle-related version upgrades#6436
ijuma merged 1 commit intoapache:trunkfrom
dejan2609:gradle-related-version-upgrades

Conversation

@dejan2609
Copy link
Copy Markdown
Contributor

@dejan2609 dejan2609 commented Mar 13, 2019 •
edited
Loading

details:

  • gradle: 5.1.1 -->> 5.4.1
  • grgit: 1.9.3 -->> 3.1.1 (breaking change release: artifact name is changed; also, Grgit.open' usage is slightly refactored)
  • gradle-versions-plugin: 0.20.0 -->> 0.21.0
  • shadow: 4.0.3 -->> 4.0.4
  • spotless-plugin-gradle: 3.17.0 -->> 3.23.0
  • checkstyle: 8.10 -->> 8.20
  • spotbugs: 3.1.8 -->> 3.1.12
  • jacoco: 0.8.2 -->> 0.8.3

related release notes:

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dejan2609 dejan2609 mentioned this pull request Mar 13, 2019
Closed
@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Mar 13, 2019

@ewencp please review.

ewencp
ewencp approved these changes Mar 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @ijuma any thoughts given you usually do the bulk dependency version upgrades?

What's notable here is that all these build dependency versions are inlined, unlike the dependencies.gradle refactoring that centralizes dependency versions and makes it easier to work through them and do updates. Either here or at some point in a PR that doesn't also do updates, it's probably worth refactoring them and basically banning version numbers from the main build.gradle script.

@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Mar 20, 2019

It goes without saying that I will volunteer for either of two solutions: expand this or create a brand new PR (with extracted versions).

@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Apr 5, 2019

Please note that now Gradle can be upgraded to 5.3.1 (also, grgit version can be bumped to 3.1.1).
I will update PR accordingly.

@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Apr 28, 2019

Another commit is added (that will be squashed eventually):

  • gradle upgrade: 5.3.1 -->> 5.4.1
  • checkstyle upgrade: 8.18 -->> 8.20         

@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Apr 28, 2019

@ijuma: please review.

ijuma
ijuma approved these changes Apr 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please update the PR description to include the latest updates?

I agree with @ewencp that it would be nice to move the plugin and gradle versions to the dependencies file in a separate PR.

@dejan2609
MINOR: gradle-related version upgrades
658db41 
details:
 * gradle:                  5.1.1  -->>  5.4.1
 * grgit:                   1.9.3  -->>  3.1.1 (breaking change release: artifact name is changed; also, Grgit.open' usage is slightly refactored)
 * gradle-versions-plugin:  0.20.0 -->> 0.21.0
 * shadow:                  4.0.3  -->>  4.0.4
 * spotless-plugin-gradle: 3.17.0  -->> 3.23.0
 * checkstyle:                8.10 -->> 8.20
 * spotbugs:                 3.1.8 -->> 3.1.12
 * jacoco:                   0.8.2 -->> 0.8.3

related release notes:
 * gradle:
       ** https://github.com/gradle/gradle/releases/tag/v5.2.0
       ** https://github.com/gradle/gradle/releases/tag/v5.2.1
       ** https://github.com/gradle/gradle/releases/tag/v5.3.0
       ** https://github.com/gradle/gradle/releases/tag/v5.3.1
       ** https://github.com/gradle/gradle/releases/tag/v5.4.0
       ** https://github.com/gradle/gradle/releases/tag/v5.4.1
 * grgit:
       ** https://github.com/ajoberstar/grgit/releases/tag/2.0.0
       ** https://github.com/ajoberstar/grgit/releases/tag/3.0.0
       ** https://github.com/ajoberstar/grgit/releases/tag/3.1.0
 * gradle-versions-plugin:
       ** https://github.com/ben-manes/gradle-versions-plugin/releases/tag/v0.21.0
 * shadow:
       ** https://github.com/johnrengelman/shadow/releases/tag/4.0.4
 * spotless-plugin-gradle:
       ** https://github.com/diffplug/spotless/blob/gradle/3.23.0/plugin-gradle/CHANGES.md
 * checkstyle:
       ** http://checkstyle.sourceforge.net/releasenotes.html#Release_8.20
 * spotbugs:
       ** https://github.com/spotbugs/spotbugs/blob/3.1.12/CHANGELOG.md
 * jacoco:
       ** https://github.com/jacoco/jacoco/releases/tag/v0.8.3
@dejan2609 dejan2609 force-pushed the gradle-related-version-upgrades branch from 44d10e7 to 658db41 Compare April 28, 2019 18:46
@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Apr 28, 2019 •
edited
Loading

@ijuma: done, PR description is updated.

All changes/commits are squashed into one and rebased onto trunk (in addition: spotless-plugin-gradle version is also bumped).
Tested locally using gradle 5.4.1 (via wrapper) and also using gradle 4.10.2 / 4.8.1 (in order to test versions currently used on Jenkins).

Separate PR (with versions extracted into dependencies file) will be created soon.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 28, 2019

Thanks. Btw, you don't need to squash, we do that when we merge.

@dejan2609
Copy link
Copy Markdown
Contributor Author

dejan2609 commented Apr 29, 2019

Thanks. Btw, you don't need to squash, we do that when we merge.

@ijuma I squashed it prior to your comment; thanx for info, good to know for any future PR.
You can merge this one: single test that failed is unrelated (presumably due to flakiness):

kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup

Error Message

java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.CoordinatorNotAvailableException: 
The coordinator is not available.

@ijuma ijuma merged commit df0adbc into apache:trunk Apr 29, 2019
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 29, 2019

Thanks for the contribution and sorry for the delay. I have merged the commit to trunk.

@dejan2609 dejan2609 mentioned this pull request Apr 29, 2019
Merged
3 tasks
@dejan2609 dejan2609 deleted the gradle-related-version-upgrades branch April 29, 2019 15:39
dhruvilshah3 added a commit to confluentinc/kafka that referenced this pull request Apr 29, 2019
@dhruvilshah3
Merge remote-tracking branch 'ak/trunk' into master-sync
f678af8 
* ak/trunk: (42 commits)
  KAFKA-8134: `linger.ms` must be a long
  KAFKA-7779; Avoid unnecessary loop iteration in leastLoadedNode (apache#6081)
  MINOR: Update Gradle to 5.4.1 and update its plugins  (apache#6436)
  MINOR: improve Session expiration notice (apache#6618)
  KAFKA-8029: In memory session store (apache#6525)
  MINOR: In-memory stores cleanup (apache#6595)
  KAFKA-7862 & KIP-345 part-one: Add static membership logic to JoinGroup protocol (apache#6177)
  KAFKA-8254: Pass Changelog as Topic in Suppress Serdes (apache#6602)
  KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583)
  KAFKA-8291 : System test fix (apache#6637)
  MINOR: Do not log retriable offset commit exceptions as errors (apache#5904)
  MINOR: Fix log message error of loadTransactionMetadata (apache#6571)
  MINOR: Fix 404 security features links (apache#6634)
  MINOR: Remove an unnecessary character from broker's startup log
  MINOR: Make LogCleaner.shouldRetainRecord more readable (apache#6590)
  MINOR: Remove implicit return statement (apache#6629)
  KAFKA-8237; Untangle TopicDeleteManager and add test cases (apache#6588)
  KAFKA-8227 DOCS Fixed missing links duality of streams tables (apache#6625)
  MINOR: reformat settings.gradle to be more readable (apache#6621)
  MINOR: Correct RestServerTest formatting
  ...

 Conflicts:
	build.gradle
	settings.gradle
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@dejan2609 @pengxiaolong
MINOR: Update Gradle to 5.4.1 and update its plugins (apache#6436)
91f9046 
Details:
 * gradle: 5.1.1  -->  5.4.1
 * grgit: 1.9.3  -->  3.1.1 (breaking change release: artifact name is changed;
also, Grgit.open' usage is slightly refactored)
 * gradle-versions-plugin: 0.20.0 --> 0.21.0
 * shadow: 4.0.3  -->  4.0.4
 * spotless-plugin-gradle: 3.17.0  --> 3.23.0
 * checkstyle: 8.10 --> 8.20
 * spotbugs: 3.1.8 --> 3.1.12
 * jacoco: 0.8.2 --> 0.8.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

@ewencp ewencp ewencp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dejan2609 @ijuma @ewencp