Not log retriable exceptions as errors#5904
Conversation
|
Hi @mjsax, @ijuma and @hachikuji, this is really a very simple pull request, which makes troubleshooting much simpler. Could you please take a look? |
|
Hi @t3hnar I have the same problem to get to a clean error log policy and just ignored ConsumerCoordinator.class in my logging config. Which is bad because errors in ConsumerRebalanceListener may be lost. So +1 for this |
|
@bvoss no feedback yet. Looks like this PR is being ignored :( |
|
@t3hnar I didn't found a related issue. Did you open one? May this is needed. |
|
@bvoss nope, I did not. |
|
@bvoss I've just created one https://issues.apache.org/jira/browse/KAFKA-7791 |
|
@hachikuji LGTM. But this is client code, so you should merge it if you think it makes sense. |
|
@hachikuji Should we get this into 2.2 ? If yes, please have a quick look (if you thinks it makes sense--I am not 100% sure) -- it's an one-liner, so should not take long. Just pinging again because code freeze is end of the week. |
|
@mjsax @hachikuji Any updates on this? It's cluttering our error log as well. |
mjsax
requested review from
cmccabe,
gwenshap,
hachikuji,
ijuma and
rajinisivaram
and removed request for
cmccabe,
gwenshap,
hachikuji,
ijuma and
rajinisivaram
|
@gwenshap Maybe you can have a look? |
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Sorry for the delay. LGTM. Thanks for the patch!
Reviewers: Jason Gustafson <jason@confluent.io>
Reviewers: Jason Gustafson <jason@confluent.io>
Reviewers: Jason Gustafson <jason@confluent.io>
* ak/trunk: (42 commits) KAFKA-8134: `linger.ms` must be a long KAFKA-7779; Avoid unnecessary loop iteration in leastLoadedNode (apache#6081) MINOR: Update Gradle to 5.4.1 and update its plugins (apache#6436) MINOR: improve Session expiration notice (apache#6618) KAFKA-8029: In memory session store (apache#6525) MINOR: In-memory stores cleanup (apache#6595) KAFKA-7862 & KIP-345 part-one: Add static membership logic to JoinGroup protocol (apache#6177) KAFKA-8254: Pass Changelog as Topic in Suppress Serdes (apache#6602) KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583) KAFKA-8291 : System test fix (apache#6637) MINOR: Do not log retriable offset commit exceptions as errors (apache#5904) MINOR: Fix log message error of loadTransactionMetadata (apache#6571) MINOR: Fix 404 security features links (apache#6634) MINOR: Remove an unnecessary character from broker's startup log MINOR: Make LogCleaner.shouldRetainRecord more readable (apache#6590) MINOR: Remove implicit return statement (apache#6629) KAFKA-8237; Untangle TopicDeleteManager and add test cases (apache#6588) KAFKA-8227 DOCS Fixed missing links duality of streams tables (apache#6625) MINOR: reformat settings.gradle to be more readable (apache#6621) MINOR: Correct RestServerTest formatting ... Conflicts: build.gradle settings.gradle
…e#5904) Reviewers: Jason Gustafson <jason@confluent.io>
5 participants
Background: I've spotted tons of kafka related errors in logs, after investigation I found out that those are harmless as being retried.
Hence I propose to not log retriable exceptions as errors.
Examples of what I've see in logs: