KAFKA-7903 : use automated protocol for offset commit request#6583
Merged
cmccabe merged 3 commits intoapache:trunkfrom Apr 25, 2019
Merged
KAFKA-7903 : use automated protocol for offset commit request#6583cmccabe merged 3 commits intoapache:trunkfrom
cmccabe merged 3 commits intoapache:trunkfrom
Conversation
abbccdda
force-pushed
the
offset_commit_auto
branch
5 times, most recently
from
4c10afe to
4e34f4f
Compare
Author
|
@cmccabe Do you have time to take a look? Thanks! |
Author
|
Retest this please |
1 similar comment
Author
|
Retest this please |
Contributor
|
thanks @abbccdda . will take a look soon! |
abbccdda
force-pushed
the
offset_commit_auto
branch
from
4e34f4f to
52f7d0b
Compare
Author
|
@cmccabe bump! |
cmccabe
reviewed
Apr 24, 2019
cmccabe
reviewed
Apr 24, 2019
Author
|
Thanks for the review, comment addressed! @cmccabe |
abbccdda
force-pushed
the
offset_commit_auto
branch
from
797e34a to
1e98e59
Compare
dhruvilshah3
added a commit
to confluentinc/kafka
that referenced
this pull request
Apr 29, 2019
* ak/trunk: (42 commits) KAFKA-8134: `linger.ms` must be a long KAFKA-7779; Avoid unnecessary loop iteration in leastLoadedNode (apache#6081) MINOR: Update Gradle to 5.4.1 and update its plugins (apache#6436) MINOR: improve Session expiration notice (apache#6618) KAFKA-8029: In memory session store (apache#6525) MINOR: In-memory stores cleanup (apache#6595) KAFKA-7862 & KIP-345 part-one: Add static membership logic to JoinGroup protocol (apache#6177) KAFKA-8254: Pass Changelog as Topic in Suppress Serdes (apache#6602) KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583) KAFKA-8291 : System test fix (apache#6637) MINOR: Do not log retriable offset commit exceptions as errors (apache#5904) MINOR: Fix log message error of loadTransactionMetadata (apache#6571) MINOR: Fix 404 security features links (apache#6634) MINOR: Remove an unnecessary character from broker's startup log MINOR: Make LogCleaner.shouldRetainRecord more readable (apache#6590) MINOR: Remove implicit return statement (apache#6629) KAFKA-8237; Untangle TopicDeleteManager and add test cases (apache#6588) KAFKA-8227 DOCS Fixed missing links duality of streams tables (apache#6625) MINOR: reformat settings.gradle to be more readable (apache#6621) MINOR: Correct RestServerTest formatting ... Conflicts: build.gradle settings.gradle
gwenshap
pushed a commit
that referenced
this pull request
May 8, 2019
KAFKA-7903: automatically generate OffsetCommitRequest (#6583) introduced a change that cause consumer breakage when OffsetCommitResponse versions < 3 are parsed, as they do not include a throttle_time_ms field. This PR fixes the parsing by supplying the correct version to the OffsetCommitResponse constructor in AbstractResponse.parseResponse. I have tested this change against many of the compatibility system tests, and it has fixed all the failures that I have tested thus far. Author: Lucas Bradstreet <lucas@confluent.io> Reviewers: Gwen Shapira, Boyang Chen Closes #6698 from lbradstreet/offset-commit-response-throttle-field
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Colin P. McCabe <cmccabe@apache.org>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583) introduced a change that cause consumer breakage when OffsetCommitResponse versions < 3 are parsed, as they do not include a throttle_time_ms field. This PR fixes the parsing by supplying the correct version to the OffsetCommitResponse constructor in AbstractResponse.parseResponse. I have tested this change against many of the compatibility system tests, and it has fixed all the failures that I have tested thus far. Author: Lucas Bradstreet <lucas@confluent.io> Reviewers: Gwen Shapira, Boyang Chen Closes apache#6698 from lbradstreet/offset-commit-response-throttle-field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sub-effort for fully auto-mated Kafka protocols.
Committer Checklist (excluded from commit message)