KAFKA-8227 DOCS Fixed missing links duality of streams tables#6625
Merged
bbejeck merged 2 commits intoapache:trunkfrom Apr 24, 2019
londoncalling:kafka-docs-8227-missing-links-duality-of-streams-tables
Merged
KAFKA-8227 DOCS Fixed missing links duality of streams tables#6625bbejeck merged 2 commits intoapache:trunkfrom londoncalling:kafka-docs-8227-missing-links-duality-of-streams-tables
bbejeck merged 2 commits intoapache:trunkfrom
londoncalling:kafka-docs-8227-missing-links-duality-of-streams-tables
Conversation
Signed-off-by: Victoria Bialas <vicky@confluent.io>
bbejeck
reviewed
Apr 24, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
@londoncalling thanks for the PR. I just have some minor comments, but otherwise this PR LGTM.
Signed-off-by: Victoria Bialas <vicky@confluent.io>
Contributor
Author
|
@mjsax , @joel-hamill , @JimGalasyn this should be good to go after build completes, can someone merge for me who has permissions? |
JimGalasyn
approved these changes
Apr 24, 2019
bbejeck
approved these changes
Apr 24, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @londoncalling! LGTM
Member
|
Merged #6625 into trunk |
Member
|
Thanks for fixing the links @londoncalling! |
bbejeck
pushed a commit
that referenced
this pull request
Apr 24, 2019
Fixed missing links duality of streams tables Reviewers: Jim Galasyn <jim.galasyn@confluent.io> Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Apr 24, 2019
Fixed missing links duality of streams tables Reviewers: Jim Galasyn <jim.galasyn@confluent.io> Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Apr 24, 2019
Fixed missing links duality of streams tables Reviewers: Jim Galasyn <jim.galasyn@confluent.io> Bill Bejeck <bbejeck@gmail.com>
Member
|
cherry-picked to 2.2, 2.1, and 2.0 |
dhruvilshah3
added a commit
to confluentinc/kafka
that referenced
this pull request
Apr 29, 2019
* ak/trunk: (42 commits) KAFKA-8134: `linger.ms` must be a long KAFKA-7779; Avoid unnecessary loop iteration in leastLoadedNode (apache#6081) MINOR: Update Gradle to 5.4.1 and update its plugins (apache#6436) MINOR: improve Session expiration notice (apache#6618) KAFKA-8029: In memory session store (apache#6525) MINOR: In-memory stores cleanup (apache#6595) KAFKA-7862 & KIP-345 part-one: Add static membership logic to JoinGroup protocol (apache#6177) KAFKA-8254: Pass Changelog as Topic in Suppress Serdes (apache#6602) KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583) KAFKA-8291 : System test fix (apache#6637) MINOR: Do not log retriable offset commit exceptions as errors (apache#5904) MINOR: Fix log message error of loadTransactionMetadata (apache#6571) MINOR: Fix 404 security features links (apache#6634) MINOR: Remove an unnecessary character from broker's startup log MINOR: Make LogCleaner.shouldRetainRecord more readable (apache#6590) MINOR: Remove implicit return statement (apache#6629) KAFKA-8237; Untangle TopicDeleteManager and add test cases (apache#6588) KAFKA-8227 DOCS Fixed missing links duality of streams tables (apache#6625) MINOR: reformat settings.gradle to be more readable (apache#6621) MINOR: Correct RestServerTest formatting ... Conflicts: build.gradle settings.gradle
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…#6625) Fixed missing links duality of streams tables Reviewers: Jim Galasyn <jim.galasyn@confluent.io> Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review Requests
@bbejeck , @mjsax , @JimGalasyn , @joel-hamill
Signed-off-by: Victoria Bialas vicky@confluent.io