MINOR: correctly parse version OffsetCommitResponse version < 3#6698
Closed
lbradstreet wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: correctly parse version OffsetCommitResponse version < 3#6698lbradstreet wants to merge 1 commit intoapache:trunkfrom
lbradstreet wants to merge 1 commit intoapache:trunkfrom
Conversation
gwenshap
approved these changes
May 8, 2019
Contributor
gwenshap
left a comment
gwenshap
left a comment
There was a problem hiding this comment.
Great catch. LGTM and merging :)
|
Thanks for the PR! LGTM |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
KAFKA-7903: automatically generate OffsetCommitRequest (apache#6583) introduced a change that cause consumer breakage when OffsetCommitResponse versions < 3 are parsed, as they do not include a throttle_time_ms field. This PR fixes the parsing by supplying the correct version to the OffsetCommitResponse constructor in AbstractResponse.parseResponse. I have tested this change against many of the compatibility system tests, and it has fixed all the failures that I have tested thus far. Author: Lucas Bradstreet <lucas@confluent.io> Reviewers: Gwen Shapira, Boyang Chen Closes apache#6698 from lbradstreet/offset-commit-response-throttle-field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-7903: automatically generate OffsetCommitRequest (#6583) introduced a change that cause consumer breakage when OffsetCommitResponse versions < 3 are parsed, as they do not include a throttle_time_ms field. This PR fixes the parsing by supplying the correct version to the OffsetCommitResponse constructor in AbstractResponse.parseResponse.
I have tested this change against many of the compatibility system tests, and it has fixed all the failures that I have tested thus far.