MINOR: Use Java 8 lambdas in KStreamImplTest#6430
Merged
guozhangwang merged 2 commits intoapache:trunkfrom Mar 12, 2019
Merged
Conversation
Member
Author
|
ping @guozhangwang, @mjsax, @vvcephei, and @ableegoldman for reviews. |
mjsax
reviewed
Mar 12, 2019
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Some nits.
| return false; | ||
| } | ||
| }); | ||
| source1.filter((key, value) -> true).filterNot((key, value) -> false); |
Member
There was a problem hiding this comment.
Should we keep one operator per line to make potential stack traces easier to read? Also simplifies setting breakpoint.
| return Collections.singletonList(new Integer(value)); | ||
| } | ||
| }); | ||
| final KStream<String, Integer> stream3 = source2.flatMapValues((ValueMapper<String, Iterable<Integer>>) value -> Collections.singletonList(new Integer(value))); |
| return value1 + value2; | ||
| } | ||
| }, JoinWindows.of(ofMillis(anyWindowSize)), joined); | ||
| final KStream<String, Integer> stream4 = streams2[0].join(streams3[0], (value1, value2) -> value1 + value2, JoinWindows.of(ofMillis(anyWindowSize)), joined); |
| return value1 + value2; | ||
| } | ||
| }, JoinWindows.of(ofMillis(anyWindowSize)), joined); | ||
| streams2[1].join(streams3[1], (value1, value2) -> value1 + value2, JoinWindows.of(ofMillis(anyWindowSize)), joined); |
Member
|
@bbejeck Can you also cleanup |
Member
Author
|
@mjsax updated this per comments |
mjsax
approved these changes
Mar 12, 2019
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: MINOR: Retain public constructors of classes from public API (apache#6455) KAFKA-8118; Ensure ZK clients are closed in tests, fix verification (apache#6456) KAFKA-7813: JmxTool throws NPE when --object-name is omitted KAFKA-8114: Wait for SCRAM credential propagation in DelegationTokenEndToEndAuthorizationTest (apache#6452) KAFKA-8111; Set min and max versions for Metadata requests (apache#6451) KAFKA-7855: Kafka Streams Maven Archetype quickstart fails to compile out of the box (apache#6194) MINOR: Update code to not use deprecated methods (apache#6434) MINOR: Update Trogdor ConnectionStressWorker status at the end of execution (apache#6445) KAFKA-8091; Use commitSync to check connection failure in listener update test (apache#6450) KAFKA-7027: Add an overload build method in scala (apache#6373) MINOR: Fix typos in LogValidator (apache#6449) KAFKA-7502: Cleanup KTable materialization logic in a single place (apache#6174) KAFKA-7730; Limit number of active connections per listener in brokers (KIP-402) KAFKA-8091; Remove unsafe produce from dynamic listener update test (apache#6443) MINOR: Fix JavaDocs warnings (apache#6435) MINOR: Better messaging for invalid fetch response (apache#6427) MINOR: Use Java 8 lambdas in KStreamImplTest (apache#6430)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Just a minor cleanup to use Java 8 lambdas vs anonymous classes in this test. I ran all tests in the streams test suite Reviewers: Matthias J. Sax <mjsax@apache.org>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor cleanup to use Java 8 lambdas vs anonymous classes in this test.
I ran all tests in the streams test suite
Committer Checklist (excluded from commit message)