Skip to content

MINOR: Fix JavaDocs warnings#6435

Merged
bbejeck merged 2 commits intoapache:trunkfrom
mjsax:fix-javadocs
Mar 13, 2019
Merged

MINOR: Fix JavaDocs warnings#6435
bbejeck merged 2 commits intoapache:trunkfrom
mjsax:fix-javadocs

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Mar 12, 2019

Fix JavaDocs Warning:

> Task :streams:javadoc
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:158: warning - invalid usage of tag <
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:164: warning - invalid usage of tag <
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:164: warning - invalid usage of tag >
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:169: warning - invalid usage of tag >
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:174: warning - invalid usage of tag >
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:174: warning - invalid usage of tag <
11:19:51 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.12/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:105: warning - invalid usage of tag >
11:19:52 7 warnings

@mjsax mjsax added the streams label Mar 12, 2019
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 12, 2019

Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman

bbejeck
bbejeck approved these changes Mar 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! LGTM

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Mar 12, 2019

LGTM! Please feel free to merge after jenkins.

@mjsax mjsax added the core Kafka Broker label Mar 12, 2019
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 12, 2019

Found more in core... \cc @hachikuji

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 12, 2019

Java11 failed with know flaky test: https://issues.apache.org/jira/browse/KAFKA-7965
Java8 passed.

Retest this please.

@bbejeck bbejeck merged commit a648ef0 into apache:trunk Mar 13, 2019
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 13, 2019

Merged #6435 into trunk

@mjsax mjsax deleted the fix-javadocs branch March 13, 2019 16:33
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
@rajinisivaram
Merge remote-tracking branch 'apache/trunk' into ccs-master
2b1f124 
* apache/trunk:
  MINOR: Retain public constructors of classes from public API (apache#6455)
  KAFKA-8118; Ensure ZK clients are closed in tests, fix verification (apache#6456)
  KAFKA-7813: JmxTool throws NPE when --object-name is omitted
  KAFKA-8114: Wait for SCRAM credential propagation in DelegationTokenEndToEndAuthorizationTest (apache#6452)
  KAFKA-8111; Set min and max versions for Metadata requests (apache#6451)
  KAFKA-7855: Kafka Streams Maven Archetype quickstart fails to compile out of the box (apache#6194)
  MINOR: Update code to not use deprecated methods (apache#6434)
  MINOR: Update Trogdor ConnectionStressWorker status at the end of execution (apache#6445)
  KAFKA-8091; Use commitSync to check connection failure in listener update test (apache#6450)
  KAFKA-7027: Add an overload build method in scala (apache#6373)
  MINOR: Fix typos in LogValidator (apache#6449)
  KAFKA-7502: Cleanup KTable materialization logic in a single place (apache#6174)
  KAFKA-7730; Limit number of active connections per listener in brokers (KIP-402)
  KAFKA-8091; Remove unsafe produce from dynamic listener update test (apache#6443)
  MINOR: Fix JavaDocs warnings (apache#6435)
  MINOR: Better messaging for invalid fetch response (apache#6427)
  MINOR: Use Java 8 lambdas in KStreamImplTest (apache#6430)
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@mjsax @pengxiaolong
MINOR: Fix JavaDocs warnings (apache#6435)
e2f3f30 
Fix JavaDocs Warning
Reviewers: uozhang Wang <wangguoz@gmail.com>,  Bill Bejeck <bbejeck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees

No one assigned

Labels

core Kafka Broker streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjsax @guozhangwang @bbejeck