KAFKA-8126: Fix flaky tests in WorkerTest#6475
Merged
rhauch merged 1 commit intoapache:trunkfrom Apr 3, 2019
Merged
Conversation
Contributor
Author
|
@mjsax @guozhangwang can you please review? |
rhauch
changed the title
Contributor
Author
|
@rhauch could you please review? |
rhauch
reviewed
Apr 3, 2019
Contributor
rhauch
left a comment
rhauch
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @adoroszlai!
rhauch
pushed a commit
that referenced
this pull request
Apr 3, 2019
…stAddRemoveTask (#6475) Changed the WorkerTest to use a mock Executor. Author: Attila Doroszlai <adoroszlai@apache.org> Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Apr 3, 2019
…stAddRemoveTask (#6475) Changed the WorkerTest to use a mock Executor. Author: Attila Doroszlai <adoroszlai@apache.org> Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Apr 3, 2019
…stAddRemoveTask (#6475) Changed the WorkerTest to use a mock Executor. Author: Attila Doroszlai <adoroszlai@apache.org> Reviewer: Randall Hauch <rhauch@gmail.com>
Contributor
Author
|
Thanks @rhauch for reviewing and merging it. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: MINOR: Add security considerations for remote JMX in Kafka docs (apache#6544) MINOR: Remove redundant access specifiers from metrics interfaces (apache#6527) MINOR: Correct KStream documentation (apache#6552) KAFKA-8013; Avoid underflow when reading a Struct from a partially correct buffer (apache#6340) KAFKA-8058: Fix ConnectClusterStateImpl.connectors() method (apache#6384) MINOR: Move common consumer tests out of abstract consumer class (apache#6548) KAFKA-8168; Add a generated ApiMessageType class KAFKA-7893; Refactor ConsumerBounceTest to reuse functionality from BaseConsumerTest (apache#6238) MINOR: Tighten up metadata upgrade test (apache#6531) KAFKA-8190; Don't update keystore modification time during validation (apache#6539) MINOR: Fixed a few warning in core and connects (apache#6545) KAFKA-7904; Add AtMinIsr partition metric and TopicCommand option (KIP-427) MINOR: fix throttling and status in ConnectionStressWorker KAFKA-8090: Use automatic RPC generation in ControlledShutdown KAFKA-6399: Remove Streams max.poll.interval override (apache#6509) KAFKA-8126: Flaky Test org.apache.kafka.connect.runtime.WorkerTest.testAddRemoveTask (apache#6475) HOTFIX: Update unit test for KIP-443 KAFKA-7190: KIP-443; Remove streams overrides on repartition topics (apache#6511) KAFKA-8183: Add retries to WorkerUtils#verifyTopics (apache#6532) KAFKA-8181: Removed Avro topic from TOC on kafka (apache#6529)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…stAddRemoveTask (apache#6475) Changed the WorkerTest to use a mock Executor. Author: Attila Doroszlai <adoroszlai@apache.org> Reviewer: Randall Hauch <rhauch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test cases in
WorkerTestby mocking theExecutorServiceinWorker. Previously, when using a real thread pool executor, the task may or may not have been run by the executor until the end of the test.Related JIRA issues:
How was this patch tested?
Ran all tests (
./gradlew test).Ran unit tests in
connect/runtimerepeatedly.