Skip to content

KAFKA-8183: Add retries to WorkerUtils#verifyTopics#6532

Merged
cmccabe merged 2 commits intoapache:trunkfrom
stanislavkozlovski:KAFKA-8183-trogdor-create-topic-retry
Apr 3, 2019
Merged

KAFKA-8183: Add retries to WorkerUtils#verifyTopics#6532
cmccabe merged 2 commits intoapache:trunkfrom
stanislavkozlovski:KAFKA-8183-trogdor-create-topic-retry

Conversation

@stanislavkozlovski
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest just using "return" here. Then you can have the loop be a regular for loop.

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Apr 2, 2019

LGTM

@stanislavkozlovski
Copy link
Copy Markdown
Contributor Author

JDK 8 build passed successfully

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Apr 3, 2019

Failing test is org.apache.kafka.streams.internals.ApiUtilsTest#shouldThrowNullPointerExceptionForNullDuration, which is not related.

@cmccabe cmccabe merged commit 4825bc4 into apache:trunk Apr 3, 2019
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* apache/trunk:
  MINOR: Add security considerations for remote JMX in Kafka docs (apache#6544)
  MINOR: Remove redundant access specifiers from metrics interfaces (apache#6527)
  MINOR: Correct KStream documentation (apache#6552)
  KAFKA-8013; Avoid underflow when reading a Struct from a partially correct buffer (apache#6340)
  KAFKA-8058: Fix ConnectClusterStateImpl.connectors() method (apache#6384)
  MINOR: Move common consumer tests out of abstract consumer class (apache#6548)
  KAFKA-8168; Add a generated ApiMessageType class
  KAFKA-7893; Refactor ConsumerBounceTest to reuse functionality from BaseConsumerTest (apache#6238)
  MINOR: Tighten up metadata upgrade test (apache#6531)
  KAFKA-8190; Don't update keystore modification time during validation (apache#6539)
  MINOR: Fixed a few warning in core and connects (apache#6545)
  KAFKA-7904; Add AtMinIsr partition metric and TopicCommand option (KIP-427)
  MINOR: fix throttling and status in ConnectionStressWorker
  KAFKA-8090: Use automatic RPC generation in ControlledShutdown
  KAFKA-6399: Remove Streams max.poll.interval override (apache#6509)
  KAFKA-8126: Flaky Test org.apache.kafka.connect.runtime.WorkerTest.testAddRemoveTask (apache#6475)
  HOTFIX: Update unit test for KIP-443
  KAFKA-7190: KIP-443; Remove streams overrides on repartition topics (apache#6511)
  KAFKA-8183: Add retries to WorkerUtils#verifyTopics (apache#6532)
  KAFKA-8181: Removed Avro topic from TOC on kafka (apache#6529)
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Reviewers: Colin P. McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants