KAFKA-7989: RequestQuotaTest should wait for quota config change before running tests#6482
Merged
rajinisivaram merged 1 commit intoapache:trunkfrom Mar 21, 2019
Merged
Conversation
rajinisivaram
approved these changes
Mar 21, 2019
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@apovzner Thanks for the PR, LGTM. Will merge after builds complete.
Contributor
|
Merging to trunk and 2.2 |
rajinisivaram
pushed a commit
that referenced
this pull request
Mar 21, 2019
…re running tests (#6482) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: (23 commits) KAFKA-7986: Distinguish logging from different ZooKeeperClient instances (apache#6493) KAFKA-8102: Add an interval-based Trogdor transaction generator (apache#6444) MINOR: Fix misspelling in protocol documentation KAFKA-8150: Fix bugs in handling null arrays in generated RPC code (apache#6489) KAFKA-8014: Extend Connect integration tests to add and remove workers dynamically (apache#6342) MINOR: Remove line for testing repartition topic name (apache#6488) MINOR: add MacOS requirement to Streams docs MINOR: fix message protocol help text for ElectPreferredLeadersResult (apache#6479) MINOR: list-topics should not require topic param MINOR: Clean up ThreadCacheTest (apache#6485) MINOR: Avoid unnecessary collection copy in MetadataCache (apache#6397) KAFKA-8142: Fix NPE for nulls in Headers (apache#6484) KAFKA-7243: Add unit integration tests to validate metrics in Kafka Streams (apache#6080) MINOR: Add verification step for Streams archetype to Jenkins build (apache#6431) KAFKA-7819: Improve RoundTripWorker (apache#6187) KAFKA-7989: RequestQuotaTest should wait for quota config change before running tests (apache#6482) KAFKA-8098: Fix Flaky Test testConsumerGroups KAFKA-6958: Add new NamedOperation interface to enforce consistency in naming operations (apache#6409) MINOR: capture result timestamps in Kafka Streams DSL tests (apache#6447) MINOR: updated names for deprecated streams constants (apache#6466) ...
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…re running tests (apache#6482) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes KAFKA-7989 and KAFKA-8123: testResponseThrottleTimeWhenBothProduceAndRequestQuotasViolated and testResponseThrottleTimeWhenBothFetchAndRequestQuotasViolated.
The failure was due to throttle-time metric for produce/consume was not updated.
The root cause of the failure is that test's
setUp()sets quota configs for various producers/consumers, which is done through admin client, but it waited for only default and unthrottled client quotas to be updated; it did not wait for quota of smallQuotaProducerClientId and smallQuotaConsumerClientId to be updated. The failed tests are those that verify throttle metrics of smallQuotaProducerClientId and smallQuotaConsumerClientId clients. One important details is that default request quota and request quota of smallQuotaConsumer/ProducerClientId are the same == 0.01. The test failure happens if the test runs before produce/consume quota gets updated (the default request quota is already small). In this case, the request gets throttled due to violating request quota, but not produce/consume quota, while the test expects that both types of quotas are violated. The fix is for the test to wait for all quotas to be updated insetUpbefore running tests.I was not able to reproduce the test failure locally. However, I was able to "reproduce" this by adding a while loop in the beginning of ClientQuotaManager#updateQuota().
Committer Checklist (excluded from commit message)