Skip to content

MINOR: Remove line for testing repartition topic name#6488

Merged
bbejeck merged 1 commit intoapache:trunkfrom
bbejeck:MINOR_remove_line_testing_repartition_topic_name
Mar 24, 2019
Merged

MINOR: Remove line for testing repartition topic name#6488
bbejeck merged 1 commit intoapache:trunkfrom
bbejeck:MINOR_remove_line_testing_repartition_topic_name

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Mar 22, 2019

With KIP-307 joined.name() is deprecated plus we don't need to test for repartition topic names.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 22, 2019

ping @guozhangwang @mjsax @vvcephei @ableegoldman for review

@mjsax mjsax added the streams label Mar 22, 2019
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 22, 2019

Java8 failed with Gradle env error.
Java11 passed.

Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 22, 2019

Java8 failed with Gradle env error.
Java11 passed.

Retest this please.

@bbejeck bbejeck merged commit c74acb2 into apache:trunk Mar 24, 2019
@bbejeck bbejeck deleted the MINOR_remove_line_testing_repartition_topic_name branch March 24, 2019 16:48
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* apache/trunk: (23 commits)
  KAFKA-7986: Distinguish logging from different ZooKeeperClient instances (apache#6493)
  KAFKA-8102: Add an interval-based Trogdor transaction generator (apache#6444)
  MINOR: Fix misspelling in protocol documentation
  KAFKA-8150: Fix bugs in handling null arrays in generated RPC code (apache#6489)
  KAFKA-8014: Extend Connect integration tests to add and remove workers dynamically (apache#6342)
  MINOR: Remove line for testing repartition topic name (apache#6488)
  MINOR: add MacOS requirement to Streams docs
  MINOR: fix message protocol help text for ElectPreferredLeadersResult (apache#6479)
  MINOR: list-topics should not require topic param
  MINOR: Clean up ThreadCacheTest (apache#6485)
  MINOR: Avoid unnecessary collection copy in MetadataCache (apache#6397)
  KAFKA-8142: Fix NPE for nulls in Headers (apache#6484)
  KAFKA-7243: Add unit integration tests to validate metrics in Kafka Streams (apache#6080)
  MINOR: Add verification step for Streams archetype to Jenkins build (apache#6431)
  KAFKA-7819: Improve RoundTripWorker (apache#6187)
  KAFKA-7989: RequestQuotaTest should wait for quota config change before running tests (apache#6482)
  KAFKA-8098: Fix Flaky Test testConsumerGroups
  KAFKA-6958: Add new NamedOperation interface to enforce consistency in naming operations (apache#6409)
  MINOR: capture result timestamps in Kafka Streams DSL tests (apache#6447)
  MINOR: updated names for deprecated streams constants (apache#6466)
  ...
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
With KIP-307 joined.name() is deprecated plus we don't need to test for repartition topic names.
Reviewers: Matthias J. Sax <mjsax@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants