MINOR: Fix system test logic to handle duplicates between kafka.properties and server_prop_overides#6949
Merged
omkreddy merged 1 commit intoapache:2.0from Jun 18, 2019
stanislavkozlovski:minor-fix-system-test-overrides
Merged
MINOR: Fix system test logic to handle duplicates between kafka.properties and server_prop_overides#6949omkreddy merged 1 commit intoapache:2.0from stanislavkozlovski:minor-fix-system-test-overrides
omkreddy merged 1 commit intoapache:2.0from
stanislavkozlovski:minor-fix-system-test-overrides
Conversation
The changes are cherry-picked from commit 914ffa9 which is present in 2.1+ versions
omkreddy
approved these changes
Jun 17, 2019
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@stanislavkozlovski Thanks for the PR. LGTM.
omkreddy
approved these changes
Jun 17, 2019
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@stanislavkozlovski Thanks for the PR. LGTM.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are cherry-picked from commit 914ffa9 which is present in 2.1+ versions
The reason for this patch is that the 2.0
log_dir_failure_test.pysystem test very frequently fails due to expecting one partition of the__consumer_offsetstopic. The override config for the partitions count is passed but gets overridden by the value in kafka.properties.