MINOR: Split at first occurrence of '=' in kafka.py props parsing (cherry-pick on 2.0)#7042
Merged
cmccabe merged 1 commit intoapache:2.0from Jul 8, 2019
Merged
Conversation
…ache#5549) This is a fix to apache#5226 to account for config properties that have an equal char in the value. Otherwise if there is one equal char in the value the following error occurs: dictionary update sequence element #XX has length 3; 2 is required Reviewers: Colin Patrick McCabe <colin@cmccabe.xyz>, Ismael Juma <ismael@juma.me.uk>
Contributor
Author
|
@ijuma @cmccabe @omkreddy I issued this PR to highlight the fix. Feel free to merge this one on 2.0 or cherry-pick the original commit instead ( #5549 ), whatever is easier. I'm not targeting |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also cherry picks the fix that was missed when #6949 cherry-picked the changes introduced by #5226 to branch 2.0. The original message of the fix is as follows:
This is a fix to #5226 to account for config properties that have an
equal char in the value. Otherwise if there is one
equal char in the value the following error occurs:
dictionary update sequence element #XX has length 3; 2 is required
Committer Checklist (excluded from commit message)