Fix for a failing upgrade test#7000
Conversation
….protocol and inter.broker.listener.name depending on kafka version
|
@rajinisivaram @brianbushree @ijuma can you please help review this PR? Please let me know if we need a full test run for it |
|
if these kafka versions don't support named listeners, can we still use |
|
@brianbushree good question. |
|
@brianbushree I suggest the following change in kafka.py: This way the only way people can get into the state where their node is running a version that doesn't support named listeners ( |
rajinisivaram
left a comment
There was a problem hiding this comment.
@stan-confluent Thanks for the PR, LGTM
|
@stan-confluent makes sense, LGTM! |
|
@stan-confluent Thanks for the PR, merging to trunk. |
…ker.protocol and inter.broker.listener.name depending on kafka version (apache#7000) Reviewers: Brian Bushree <bbushree@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
…ker.protocol and inter.broker.listener.name depending on kafka version (apache#7000) Reviewers: Brian Bushree <bbushree@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
…ker.protocol and inter.broker.listener.name depending on kafka version (#7000) Reviewers: Brian Bushree <bbushree@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
Previous PR (#6938) added partial support for named listeners to kafka.py. Though we did run full test suite, somehow we missed one of the upgrade tests.
Since upgrade tests start kafka from older versions, they may try to start it from a version that doesn't support named listeners yet.
This PR addresses the issue by adding a method to
version.pycalledsupports_named_listeners()and calling that method from kafka.properties template.According to KIP-103 (KAFKA-4636),
inter.broker.listener.nameproperty was introduced in 0.10.2.0, so I used this value insupports_named_listeners()method.Testing:
Verified that a previously failing test passes locally.
Ran upgrade tests on Jenkins - https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2747, all green
Committer Checklist (excluded from commit message)