MINOR: Pass KafkaVersion to nodes in KafkaService. Related to PR#7000#7025
Closed
rhauch wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Pass KafkaVersion to nodes in KafkaService. Related to PR#7000#7025rhauch wants to merge 1 commit intoapache:trunkfrom
rhauch wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
System tests build with this change: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2765/ |
3 tasks
Contributor
rajinisivaram
left a comment
There was a problem hiding this comment.
Contributor
Author
|
Thanks, Rajini. Closing without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7000 added a
KafkaVersion.support_named_listeners()method and used this intests/kafkatest/services/kafka/templates/kafka.properties. However, ifKafkaServiceexpects theversionparameter to be a string (as denoted in the doc), thenKafkaServiceneeds to construct aKafkaVersionand pass it to the nodes rather than passing the string, since the string does not have thesupport_named_listeners()method.This could be an alternative to #7023.
Committer Checklist (excluded from commit message)