MINOR: Add more versions to connect compatibility#7024
Conversation
a4ab685 to
84b7f74
Compare
|
See https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2762/ for system test run with just the affected system test method. |
|
Actually, this is currently dependent upon #7023, but #7025 is an alternative to #7023. If #7025 is chosen, then this probably needs to be updated to remove the first commit. |
84b7f74 to
7028edf
Compare
7028edf to
e0fa759
Compare
|
Rebased on trunk since #7023 was merged (and #7025 was not). @kkonstantine, would you mind reviewing to make sure these combinations are acceptable? |
kkonstantine
left a comment
There was a problem hiding this comment.
Good to have increased coverage.
LGTM!
|
Started another test run of just this parameterized test so we can measure how long it takes to run the tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2817/ |
|
This change results in 22 different test variations for this one method, and the last branch builder run took ~17 minutes to run all 22 tests. That is not a significant increase in time, so IMO this extra validation is worth the minimal cost. @rajinisivaram or @hachikuji, could one of you review and merge back to the 2.3 branch? |
|
@rajinisivaram or @hachikuji: ping again for review and merge back to the 2.3 branch. |
|
LGTM |
ConnectDistributedTest.test_broker_compatibilityhasn't been updated with recent Kafka versions in quite some time.This can be merged to
trunkand easily backported to2.3, but if backported farther back some versions would have to be removed for each branch. For example, the2.2branch should not have a compatibility test for 2.3, and the2.1branch should not have a compatibility test for 2.3 or 2.2.Committer Checklist (excluded from commit message)