KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema#7082
KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema#7082bbejeck merged 2 commits intoapache:trunkfrom
Conversation
|
Any chance I can get some feedback on this PR? Is there anything wrong, should anything be corrected? |
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Thanks for the PR @bfncs !
Just a nit regarding imports but otherwise, LGTM
|
Thanks for reviewing, @kkonstantine. The PR is already quite old, had to merge master again and reorder, should be ok now. |
|
retest this please |
1 similar comment
|
retest this please |
|
I also run into this, @bfncs are you able to pick this up again, or can I help? |
bfncs
force-pushed
the
kafka-8659
branch
2 times, most recently
from
0cc8537 to
5f9dd75
Compare
|
I finally adopted the patch to the current trunk. The CI test run here failed though, while at least all tests from the related connect transforms package run for me locally. Can anyone please retrigger and check tests and provide guidance on how to continue, please? @kkonstantine maybe? |
|
Does anyone have a pointer how we can proceed here? |
|
the changes are small enough... but looking at other PRs seems they all are failing, too... |
|
It would be nice to finally have this merged. Is there anything I could do to help? |
@bfncs kicked off the build again if we get green test runs I think we can merge this \cc @kkonstantine |
|
@bfncs sorry to ask this, but I just noticed the date of the last commit - do you mind doing a rebase? Apologies again for not noticing before |
|
Thanks for picking this up, @bbejeck! I merged trunk into the feature branch again. |
|
Test failures are unrelated |
|
Thanks, @bfncs for the contribution and your patience! |
|
@bfncs I've also added you as a contributor on Jira so you'll be able to assign tickets to yourself in the future |
…7082) Make SetSchemaMetadata SMT ignore records with null value and valueSchema or key and keySchema. The transform has been unit tested for handling null values gracefully while still providing the necessary validation for non-null values. Reviewers: Konstantine Karantasis<konstantine@confluent.io>, Bill Bejeck <bbejeck@apache.org>
|
Thanks for reviewing, merging and adding me to Jira, @bbejeck. 💐 |
…7082) Make SetSchemaMetadata SMT ignore records with null value and valueSchema or key and keySchema. The transform has been unit tested for handling null values gracefully while still providing the necessary validation for non-null values. Reviewers: Konstantine Karantasis<konstantine@confluent.io>, Bill Bejeck <bbejeck@apache.org>
|
Merged to trunk, 3.0 and 3.1 branches |
…pache#7082) Make SetSchemaMetadata SMT ignore records with null value and valueSchema or key and keySchema. The transform has been unit tested for handling null values gracefully while still providing the necessary validation for non-null values. Reviewers: Konstantine Karantasis<konstantine@confluent.io>, Bill Bejeck <bbejeck@apache.org>
4 participants
Make SetSchemaMetadata SMT ignore records with null
valueandvalueSchemaorkeyandkeySchema.The transform has been unit tested for handling null values gracefully while still providing the necessary validation for non-null values.