KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema#7080
Closed
bfncs wants to merge 4 commits intoapache:trunkfrom
Closed
KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema#7080bfncs wants to merge 4 commits intoapache:trunkfrom
bfncs wants to merge 4 commits intoapache:trunkfrom
Conversation
…or bytes and array fields Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Stanislav Kozlovski, Gwen Shapira Closes apache#7059 from cmccabe/KAFKA-8644
The purpose of this patch is to restrict the paths for updating and accessing the high watermark and the last stable offset. By doing so, we can validate that these offsets always remain within the range of the log. We also ensure that we never expose `LogOffsetMetadata` unless it is fully materialized. Finally, this patch makes a few naming changes. In particular, we remove the `highWatermark_=` and `highWatermarkMetadata_=` which are both misleading and cumbersome to test. Reviewers: David Arthur <mumrah@gmail.com>
) This patch fixes a compatibility breaking `MemberDescription` constructor change in apache#6957. It also updates `equals` and `hashCode` for the new `groupInstanceId` field that was added in the same patch. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
Contributor
Author
|
Please just ignore this PR, I messed up the commit history… see #7082. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SetSchemaMetadata SMT ignore records with null
valueandvalueSchemaorkeyandkeySchema.The transform has been unit tested for handling null values gracefully while still providing the necessary validation for non-null values.