Skip to content

MINOR: Update dependencies for Kafka 2.4#7126

Merged
ijuma merged 6 commits intoapache:trunkfrom
ijuma:update-deps-kafka-2.4-july
Aug 8, 2019
Merged

MINOR: Update dependencies for Kafka 2.4#7126
ijuma merged 6 commits intoapache:trunkfrom
ijuma:update-deps-kafka-2.4-july

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Jul 28, 2019 •
edited
Loading

Scala 2.12.9 brings another 5% ~ 10% improvement in compiler performance,
improved compatibility with JDK 11/12/13, and experimental infrastructure for
build pipelining.

zstd update includes performance improvements, among which the
primary improvement is that decompression is ~7% faster.

Level v1.4.0 v1.4.1 Delta
1 1390 MB/s 1453 MB/s +4.5%
3 1208 MB/s 1301 MB/s +7.6%
5 1129 MB/s 1233 MB/s +9.2%
7 1224 MB/s 1347 MB/s +10.0%
16 1278 MB/s 1430 MB/s +11.8%

Jetty 9.4.19 includes a number of bug fixes:
https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.19.v20190610

Mockito 3.0.0 switched the Java requirement from 7 to 8.

Several updates to owaspDepCheckPlugin (4.0.2 -> 5.2.1).

The rest are patch updates.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma force-pushed the update-deps-kafka-2.4-july branch from 6388167 to 382fb00 Compare July 28, 2019 06:23
@ijuma ijuma force-pushed the update-deps-kafka-2.4-july branch from 382fb00 to b6ab120 Compare August 6, 2019 03:04
@ijuma ijuma marked this pull request as ready for review August 7, 2019 06:01
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 7, 2019

Passed: JDK 11 with Scala 2.13 and JDK 8 with Scala 2.11. JDK 11 with Scala 2.12 had flaky unrelated failures:

kafka.api.AdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevels
kafka.api.AdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevelsCanResetLoggerToCurrentRoot
kafka.api.GroupEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
kafka.api.SaslSslAdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevels
kafka.api.SaslSslAdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevelsCanResetLoggerToCurrentRoot

@ijuma ijuma force-pushed the update-deps-kafka-2.4-july branch from b6ab120 to c287a74 Compare August 7, 2019 06:04
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 7, 2019

Rebased and triggered a new build.

@ijuma ijuma requested a review from rajinisivaram August 7, 2019 07:12
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 7, 2019

Retest this please

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 7, 2019

Retest this please.

1 similar comment
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 8, 2019

Retest this please.

rajinisivaram
rajinisivaram approved these changes Aug 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma Thanks for the PR, LGTM

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 8, 2019

Test failures are unrelated and happening in master:

kafka.api.AdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevels
kafka.api.AdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevelsCanResetLoggerToCurrentRoot
kafka.api.SaslSslAdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevels
kafka.api.SaslSslAdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevelsDoesNotWorkWithInvalidConfigs
kafka.api.SaslSslAdminClientIntegrationTest.testIncrementalAlterConfigsForLog4jLogLevelsCanResetLoggerToCurrentRoot

One of the builds timed out. The Scala 2.12 build passed, which is the most important one given the bump in Scala 2.12 version, passed.

Merging to master.

@ijuma ijuma merged commit 66d81a0 into apache:trunk Aug 8, 2019
@ijuma ijuma deleted the update-deps-kafka-2.4-july branch August 8, 2019 13:01
@ijuma ijuma mentioned this pull request Aug 8, 2019
Merged
3 tasks
ijuma added a commit to confluentinc/kafka that referenced this pull request Aug 8, 2019
@ijuma
Sync from apache/kafka (8 August 2019) and upgrade avro to 1.9.0
430f014 
The avro upgrade was needed to fix the following error during
':support-metrics-client:generateAvro':

Caused by: org.apache.velocity.exception.MethodInvocationException: Variable $velocityCount has not been set at /org/apache/avro/compiler/specific/templates/java/classic/record.vm[line 82, column 150]

Conflicts:
 * gradle.properties -> trivial fix, `scalaVersion` is next to `version`, which
 is different in ccs kafka
 * gradle/dependencies.gradle -> reduce divergence with apache kafka by using
 `httpclient` instead of `httpcomponents` from the `versions` array. Remove
 unused `httpmime` and `httpcomponents` from said array.

* apache-github/trunk:
  MINOR: Update dependencies for Kafka 2.4 (apache#7126)
  KAFKA-8599: Use automatic RPC generation in ExpireDelegationToken
  MINOR: Upgrade jackson-databind to 2.9.9.3 (apache#7125)
  MINOR: some small style fixes to RoundRobinPartitioner
  KAFKA-8736: Streams performance improvement, use isEmpty() rather than size() == 0 (apache#7164)
  Minor: Refactor methods to add metrics to sensor in `StreamsMetricsImpl` (apache#7161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajinisivaram rajinisivaram rajinisivaram approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijuma @rajinisivaram